This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)". The branch, master has been updated via 7ffa7b095fbea0f7f52a4179402edb04249c60d0 (commit) from 322b1499cd4d34b0148a15cb615ad6dff8203ed2 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- http://cgit.osmocom.org/openbsc/commit/?id=7ffa7b095fbea0f7f52a4179402edb04… commit 7ffa7b095fbea0f7f52a4179402edb04249c60d0 Author: Jacob Erlbeck <jerlbeck(a)sysmocom.de> Date: Thu Apr 9 14:47:18 2015 +0200 nitb: Fix IMSI/IMEI buffer handling (Coverity) Currently the handling of the buffers is not done consistently. Some code assumes that the whole buffer may be used to store the string while at other places, the last buffer byte is left untouched in the assumption that it contains a terminating NUL-character. The latter is the correct behaviour. This commit changes to code to not touch the last byte in the buffers and to rely on the last byte being NUL. So the maximum IMSI/IMEI length is GSM_IMSI_LENGTH-1/GSM_IMEI_LENGTH-1. For information: We assume that we allocate the structure with talloc_zero. This means we have NULed the entire imsi array and then only write sizeof - 1 characters to it. So the last byte remains NUL. Fixes: Coverity CID 1206568, 1206567 Sponsored-by: On-Waves ehf ----------------------------------------------------------------------- Summary of changes: openbsc/src/libcommon/gsm_subscriber_base.c | 3 +-- openbsc/src/libmsc/db.c | 4 ++-- openbsc/src/osmo-bsc_nat/bsc_ussd.c | 2 +- 3 files changed, 4 insertions(+), 5 deletions(-) hooks/post-receive -- The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)