[PATCH net-next v1 1/3] gtp: refactor to support flow-based gtp encap and decap
laforge at gnumonks.org
Fri Jul 14 08:15:13 UTC 2017
> > > gtp = netdev_priv(dev);
> > > + gtp->net = src_net;
> > Isn't this a generic change that's independent of your work on OVS GTP?
> It is meant to be OVS independent. What makes it not? Should I leave
> this field un-initialized?
In general, in all FOSS projects I have worked (and particularly the
Linux kernel), it is a strict rule that any given patch adresses only
one logical change. So if your change is for flow-based "OVS" support
in the GTP code, and the "gtp->net = src_net" is a generic change (and
not something specifically required by flow/OVS) then it should be a
separate patch. Similarly to the cosmetic changes which should be a
- Harald Welte <laforge at gnumonks.org> http://laforge.gnumonks.org/
"Privacy in residential applications is a desirable marketing option."
(ETSI EN 300 175-7 Ch. A6)
More information about the osmocom-net-gprs