This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/osmocom-net-gprs@lists.osmocom.org/.
Harald Welte laforge at gnumonks.orgHi Bhargava,
On Tue, Mar 22, 2016 at 06:42:30PM +0530, Bhargava Abhyankar wrote:
> Parsing the uplink data header for GPRS and EGPRS header type 3
> is handled in separate functions.
> This patch will enhance modularity of the code.
I'm not an expert on OsmoPCU, but this patch looks pretty
straight-forward and undisputable. Moving away from large switch
statements towards separate functions/methods is generally appreciated
a lot, as is increasing modularity.
--
- Harald Welte <laforge at gnumonks.org> http://laforge.gnumonks.org/
============================================================================
"Privacy in residential applications is a desirable marketing option."
(ETSI EN 300 175-7 Ch. A6)