This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/osmocom-net-gprs@lists.osmocom.org/.
Holger Freyther holger at freyther.de> On 21 Jun 2016, at 09:58, Aravind Sirsikar <Arvind.Sirsikar at radisys.com> wrote: > > Hi Holger, > >> Line 130: GprsCodingScheme cs_current_trans; >> I would prefer to cs and cs_current_trans being private here. > > The cs_current_trans is made public to align with existing variables like block[RLC_MAX_LEN], len and others to have consistency. will it make sense to have cs and cs_current_trans as private?. > > We can rename cs to cs_last_tx as suggested in review of other patch. But it will have modification in other source files to address compilation errors. please keep the communication about the modification in gerrit. If in two years we look at the change we will not know that there was communication out-of-band. If you add this comment to your change I will follow-up in gerrit. thank you for your consideration holger