This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/osmocom-net-gprs@lists.osmocom.org/.
Neels Hofmeyr nhofmeyr at sysmocom.deOn Fri, Dec 23, 2016 at 04:46:50PM +0100, Neels Hofmeyr wrote: > if (!msg) { > tbf = NULL; > > If this is not the last for() iteration, setting tbf = NULL makes no sense, it > will be set to next_list[..] at the start of the next iteration. > > If this *is* the last iteration, tbf = NULL makes no sense either, because msg > is NULL and tbf will be set to dl_ass_tbf or ul_ass_tbf in the if (!msg) {} > case below. Ah, wrong, if both dl_ass_tbf and ul_ass_tbf below are null, this has an effect. Maybe it would make slightly more sense to add "else tbf = NULL" below instead. > > continue; > } > > pdch->next_ctrl_prio += 1; > pdch->next_ctrl_prio %= 3; > break; > } > > if (!msg) { > /* > * If one of these is left, the response (CONTROL ACK) from the > * MS will kill the current TBF, only one of them can be > * non-NULL > */ > if (dl_ass_tbf) { > tbf = dl_ass_tbf; > msg = dl_ass_tbf->create_dl_ass(fn, ts); > } else if (ul_ass_tbf) { > tbf = ul_ass_tbf; > msg = ul_ass_tbf->create_ul_ass(fn, ts); > } > } -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: <http://lists.osmocom.org/pipermail/osmocom-net-gprs/attachments/20161223/b8579c9b/attachment.bin>