[PATCH 4/4] Add test cases to support MCS change during Retx

Holger Freyther holger at freyther.de
Tue Apr 12 14:32:50 UTC 2016

> On 11 Apr 2016, at 06:45, Aravind Sirsikar <Arvind.Sirsikar at radisys.com> wrote:
> From: Aravind Sirsikar <arvind.sirsikar at radisys.com>
> Add test cases to verify the MCS change functionality.
> During MCS upgradation such as MCS6->MCS9, 2 blocks
> which were sent separately as MCS6, will be clubbed into
> one MCS9 block during retransmission. Same holds good for
> MCS5->MCS7 transistion. During MCS reduction such as
> MCS9->MCS6,2 blocks which were sent together will be
> sent separately during the retransmission case. Same is
> verified through the generated log file. Currently
> MCS8->MCS6 transition is not supported. The retransmission
> MCS is being calculated from Table of TS 44.060.

We do testing in two ways:

1.) Use OSMO_ASSERT to assert a certain side-effect/result
2.) Capture the output to catch accidental changes

In your case only 2nd is done. It is good as it establishes a baseline but it is not sufficient as no actual side-effect/result is being asserted. E.g. as a reviewer it is very hard/time consuming to go through the debug log to actually find the re-transmission. So please add more strong post conditions to the test.

kind regards

More information about the osmocom-net-gprs mailing list