[PATCH] Handle the encoding of PUAN for CRBB bitmap

Holger Freyther holger at freyther.de
Tue Apr 12 14:28:48 UTC 2016


> On 11 Apr 2016, at 08:48, sangamesh sajjan <sangamesh.sajjan at radisys.com> wrote:
> 

Hi,

> This patch includes the changes for encoding of PUAN to
> handle the CRBB bitmap

same as with Haralds mail. How was this tested? Can you add a testcase for it? In manual tests how often are the bitmaps compressed in manual  tests? Under which conditions?



> +	for (i = 0, bsn = (v_q()+1); ((bsn < (v_r())) && (i < ws())); i++,
> +					bsn = this->mod_sns(bsn + 1)) {
> +		if (m_v_n.is_received(bsn)) {
> +			rbb[pos] = rbb[pos] | bitmask;
> +		} else {
> +			rbb[pos] = rbb[pos] & (~bitmask);
> +		}

coding style issue and hard to read. By itself such a method would be easy to unit test. Could you please add a test?

holger



More information about the osmocom-net-gprs mailing list