[PATCH 1/2] Fix bug in uplink header type 1 parsing

Holger Freyther holger at freyther.de
Thu Apr 7 22:22:21 UTC 2016


> On 08 Apr 2016, at 00:19, Holger Freyther <holger at freyther.de> wrote:
> 
> 
>> On 07 Apr 2016, at 13:57, Bhargava Abhyankar <Bhargava.Abhyankar at radisys.com> wrote:
>> 
>> Fix bug in extraction of E and TI header fields in parsing of uplink
>> header type 1 RLC data block. Test suite for the same is also updated.
>> 
> 
>> -	e_ti_header = (data[offs-1] + (data[offs] << 8)) >> 7;
>> +	e_ti_header = (data[offs - 1] & (0xc0)) >> 6;
> 
> Could you please elaborate about this hunk? What is the issue, how was it found, how are we certain that this is the fix?

And you can confirm that this is an issue in code we have not merged yet? In that case it should be fixed before including a wrong version.

thank you
	holger


More information about the osmocom-net-gprs mailing list