[PATCH 4/8] tbf: Create an assign method for IMSI.

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/osmocom-net-gprs@lists.osmocom.org/.

Holger Freyther hfreyther at sysmocom.de
Wed Oct 16 14:23:44 UTC 2013


From: Holger Hans Peter Freyther <holger at moiji-mobile.com>

This will allow us to set flags (like IMSI) present and will
be of help when fixing the tbf lookup.
---
 src/tbf.cpp | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/src/tbf.cpp b/src/tbf.cpp
index 5161e92..fc8d229 100644
--- a/src/tbf.cpp
+++ b/src/tbf.cpp
@@ -36,6 +36,12 @@ static inline void tbf_update_ms_class(struct gprs_rlcmac_tbf *tbf,
 		tbf->ms_class = ms_class;
 }
 
+static inline void tbf_assign_imsi(struct gprs_rlcmac_tbf *tbf,
+					const char *imsi)
+{
+	strncpy(tbf->meas.imsi, imsi, sizeof(tbf->meas.imsi) - 1);
+}
+
 static struct gprs_rlcmac_tbf *tbf_lookup_dl(const uint32_t tlli, const char *imsi)
 {
 	/* TODO: look up by IMSI first, then tlli, then old_tlli */
@@ -179,7 +185,7 @@ int tbf_handle(struct gprs_rlcmac_bts *bts,
 		gprs_rlcmac_trigger_downlink_assignment(tbf, old_tbf, imsi);
 	}
 
-	/* store IMSI for debugging purpose */
-	strncpy(tbf->meas.imsi, imsi, sizeof(tbf->meas.imsi) - 1);
+	/* store IMSI for debugging purpose. TODO: it is more than debugging */
+	tbf_assign_imsi(tbf, imsi);
 	return 0;
 }
-- 
1.8.4.rc3





More information about the osmocom-net-gprs mailing list