[PATCH 7/9] bssgp: The method creates and the connects.. reflect that in the name

Holger Hans Peter Freyther hfreyther at sysmocom.de
Tue Jul 30 19:26:45 UTC 2013


From: Holger Hans Peter Freyther <holger at moiji-mobile.com>

Call things by what they do. This method is creating and then connecting
a BSSGP..
---
 src/gprs_bssgp_pcu.cpp | 2 +-
 src/gprs_bssgp_pcu.h   | 2 +-
 src/pcu_l1_if.cpp      | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/gprs_bssgp_pcu.cpp b/src/gprs_bssgp_pcu.cpp
index e994f9f..ae47fb2 100644
--- a/src/gprs_bssgp_pcu.cpp
+++ b/src/gprs_bssgp_pcu.cpp
@@ -592,7 +592,7 @@ static void bvc_timeout(void *_priv)
 }
 
 /* create BSSGP/NS layer instances */
-int gprs_bssgp_create(uint16_t local_port, uint32_t sgsn_ip,
+int gprs_bssgp_create_and_connect(uint16_t local_port, uint32_t sgsn_ip,
 	uint16_t sgsn_port, uint16_t nsei, uint16_t nsvci, uint16_t bvci,
 	uint16_t mcc, uint16_t mnc, uint16_t lac, uint16_t rac,
 	uint16_t cell_id)
diff --git a/src/gprs_bssgp_pcu.h b/src/gprs_bssgp_pcu.h
index dff86a3..b611a19 100644
--- a/src/gprs_bssgp_pcu.h
+++ b/src/gprs_bssgp_pcu.h
@@ -49,7 +49,7 @@ int gprs_bssgp_pcu_rx_sign(struct msgb *msg, struct tlv_parsed *tp, struct bssgp
 
 int gprs_bssgp_pcu_rcvmsg(struct msgb *msg);
 
-int gprs_bssgp_create(uint16_t local_port, uint32_t sgsn_ip, uint16_t
+int gprs_bssgp_create_and_connect(uint16_t local_port, uint32_t sgsn_ip, uint16_t
 		sgsn_port, uint16_t nsei, uint16_t nsvci, uint16_t bvci,
 		uint16_t mcc, uint16_t mnc, uint16_t lac, uint16_t rac,
 		uint16_t cell_id);
diff --git a/src/pcu_l1_if.cpp b/src/pcu_l1_if.cpp
index 4452f0f..b7b0269 100644
--- a/src/pcu_l1_if.cpp
+++ b/src/pcu_l1_if.cpp
@@ -418,7 +418,7 @@ bssgp_failed:
 	ia.s_addr = htonl(info_ind->remote_ip[0]);
 	LOGP(DL1IF, LOGL_DEBUG, " remote_ip=%s\n", inet_ntoa(ia));
 
-	rc = gprs_bssgp_create(info_ind->local_port[0],
+	rc = gprs_bssgp_create_and_connect(info_ind->local_port[0],
 		info_ind->remote_ip[0], info_ind->remote_port[0],
 		info_ind->nsei, info_ind->nsvci[0], info_ind->bvci,
 		info_ind->mcc, info_ind->mnc, info_ind->lac, info_ind->rac,
-- 
1.8.3.2





More information about the osmocom-net-gprs mailing list