This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/osmocom-net-gprs@lists.osmocom.org/.
Holger Hans Peter Freyther hfreyther at sysmocom.deOn Tue, Jul 30, 2013 at 12:56:59PM +0400, Ivan Kluchnikov wrote: > Hi Holger, Dear Ivan, thanks a lot. > +static struct osmo_pcu the_pcu = { 0, }; > Why do you use "the_pcu", not "pcu"? I wanted to differentiate that 'pcu' is not a local variable. I could have picked g_pcu or something else. I used 'the' because there is only one pcu right now. I will remove that limit though (and remove global state from the PCU). > Now I am ready for new patchset. Thanks. I will send things tomorrow. > What is the reasonable amount of time for patchset review for you? > Sometimes I am overloaded by other work, but I will try to delay review no > longer than 1-2 days. 'reasonable' anything < 5 days. I just want to avoid ending with 40 patches and you as the maintainer not having time to look at them. E.g. for OpenBSC I try to at least give a quick NACK/or ask for changes. > Another mode, you can commit patches to master by yourself and just notify > about it mailing list. I would love to have more eyes before the commit hits the repository. Everybody is making mistakes and it would be nice if mine are catched with review too. cheers holger -- - Holger Freyther <hfreyther at sysmocom.de> http://www.sysmocom.de/ ======================================================================= * sysmocom - systems for mobile communications GmbH * Schivelbeiner Str. 5 * 10439 Berlin, Germany * Sitz / Registered office: Berlin, HRB 134158 B * Geschaeftsfuehrer / Managing Directors: Holger Freyther, Harald Welte