libosmocore.git branch master updated. 0.9.0-284-g6176b6e

gitosis at osmocom.org gitosis at osmocom.org
Fri Nov 11 14:57:15 UTC 2016


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "An utility library for Open Source Mobile Communications".

The branch, master has been updated
       via  6176b6e0924f2bd7d212472bcba9dddf8ac32f51 (commit)
      from  c4193d30e82307b87a7a7bce3ea5ed48f2f2f716 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://cgit.osmocom.org/libosmocore/commit/?id=6176b6e0924f2bd7d212472bcba9dddf8ac32f51

commit 6176b6e0924f2bd7d212472bcba9dddf8ac32f51
Author: Harald Welte <laforge at gnumonks.org>
Date:   Fri Nov 11 15:10:33 2016 +0100

    bssgp_rx_paging(): Fix parsing of P-TMSI IE in Paging message
    
    This was actually discovered by the following compiler warning in
    gcc-6.2.0:
    
      CC       gprs_bssgp_bss.lo
    gprs_bssgp_bss.c: In function ‘bssgp_rx_paging’:
    gprs_bssgp_bss.c:544:2: warning: this ‘if’ clause does not guard...
    [-Wmisleading-indentation]
      if (TLVP_PRESENT(&tp, BSSGP_IE_TMSI) &&
      ^~
    gprs_bssgp_bss.c:548:3: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the ‘if’
       *(pinfo->ptmsi) = ntohl(*(uint32_t *)
       ^
    
    This is an actual bug.  If we recevied a BSSGP Paging Request without
    P-TMSI, we might crash or report some random memory as P-TMSI to the
    caller in the output data structure.
    
    Change-Id: Ib4f307827cd7cccc91c1415a6fb5428d7cf8416d

-----------------------------------------------------------------------

Summary of changes:
 src/gb/gprs_bssgp_bss.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)


hooks/post-receive
-- 
An utility library for Open Source Mobile Communications



More information about the osmocom-commitlog mailing list