openbsc.git branch master updated. 0.15.0-620-g532480a

gitosis at gitosis at
Sat Dec 24 17:07:55 UTC 2016

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)".

The branch, master has been updated
       via  532480a705726452ace30b1a914640d984dd0418 (commit)
       via  db142dc59dc8d79d8ee608c9165bc865d240b97d (commit)
      from  a191dcd8f01767b266b85578d0fb445d864dfabd (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------

commit 532480a705726452ace30b1a914640d984dd0418
Author: Philipp <pmaier at>
Date:   Fri Dec 23 11:05:11 2016 +0100

    cosmetic: Rename phone to ms
    The term "phone" is incorrect. Rename phone to "MS" (mobile station)
    in the comments and log output of gprs_llc.c
    Change-Id: I322d3d99452502da7555cc2af6bc8a192ca3c9c5

commit db142dc59dc8d79d8ee608c9165bc865d240b97d
Author: Philipp <pmaier at>
Date:   Thu Dec 22 14:15:20 2016 +0100

    sndcp: Allow empty SNDCP-XID indications
    In some rare cases the modem might send a xid indication that does
    not contain anything except the version number field. The sgsn
    ignors such SNDCP-XID indications by stripping the entire field
    from the response. We found a modem in the wild that started to
    act problematic when the empty SNDCP-XID was missing in the
    response. This patch changes the XID negotiation behaviour in
    a way that if a modem should send empty SNDCP-XID indications,
    the reply will also contain an empty SNDCP-XID indication. Apart
    from that the SNDCP-XID version number is now parsed and echoed
    in the response. This ensures that we always reply with the version
    number that the modem expects. (The version was 0 in all cases we
    observed so far)
    Change-Id: I097a770cb4907418f53e620a051ebb8cd110c5f2
    Related: OS#1794


Summary of changes:
 openbsc/include/openbsc/gprs_sndcp_xid.h | 14 +++++----
 openbsc/src/gprs/gprs_llc.c              | 14 ++++-----
 openbsc/src/gprs/gprs_sndcp.c            | 25 +++++++--------
 openbsc/src/gprs/gprs_sndcp_xid.c        | 54 +++++++++++++++++++++-----------
 openbsc/tests/sndcp_xid/sndcp_xid_test.c | 10 +++---
 5 files changed, 68 insertions(+), 49 deletions(-)

The OpenBSC GSM Base Station Controller (+MSC/HLR/SGSN)

More information about the osmocom-commitlog mailing list