libosmocore.git branch master updated. 0.9.6-32-gc014f60

gitosis at gitosis at
Sat Dec 24 17:12:09 UTC 2016

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "An utility library for Open Source Mobile Communications".

The branch, master has been updated
       via  c014f606d055bb0ab09b6b9128078cb7a4e06c4c (commit)
       via  eeacf906dd961002dba7e53ec9144d08a2b2d0ee (commit)
       via  c7155df3ecb0a4f583a7d0e0bedc8cbb847a8fb4 (commit)
       via  b805cc19925b6815957ff470696887bfd74f2639 (commit)
       via  cba8eb9b21afd26ce65ef5098f6a178bce800bb7 (commit)
      from  1514f34dcfed3a8c46678861c488f7dbde856957 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------

commit c014f606d055bb0ab09b6b9128078cb7a4e06c4c
Author: Neels Hofmeyr <nhofmeyr at>
Date:   Fri Dec 23 04:26:39 2016 +0100

    fsm: factor out osmo_fsm_inst_term_children() from osmo_fsm_inst_term()
    osmo_fsm_inst_term() has code for safe child removal, publish that part as
    osmo_fsm_inst_term_children(); also use from osmo_fsm_inst_term().
    As with osmo_fsm_inst_term(), add osmo_fsm_inst_term_children() macro to pass
    the caller's source file and line to new _osmo_fsm_inst_term_children().
    Rationale: in openbsc's VLR, I want to discard child FSMs when certain events
    are handled. I could keep a pointer to each one, or simply iterate all
    children, making the code a lot simpler in some places.
    (Unfortunately, the patch may be displayed subobtimally. This really only moves
    the children-loop to a new function, replaces it with a call to
    _osmo_fsm_inst_term_children(fi, OSMO_FSM_TERM_PARENT, NULL, file, line) and
    drops two local iterator variables. No other code changes are made, even though
    the diff may show large removal + addition chunks)
    Change-Id: I8dac1206259cbd251660f793ad023aaa1dc705a2

commit eeacf906dd961002dba7e53ec9144d08a2b2d0ee
Author: Neels Hofmeyr <nhofmeyr at>
Date:   Fri Dec 23 01:00:13 2016 +0100

    fsm: move LOGPFSMSRC and LOGPFSMLSRC to .h
    LOGPFSM and LOGPFSML are in the header file, put the *SRC variants also there
    so users of the osmo_fsm_inst API may conveniently create own functions that
    log the caller's source file and line.
    Very useful if many action functions call the same event dispatching function,
    like foo_fsm_done(), and one needs to know which of the callers to debug.
    Change-Id: I39447b1d15237b28f88d8c5f08d82c764679dc80

commit c7155df3ecb0a4f583a7d0e0bedc8cbb847a8fb4
Author: Neels Hofmeyr <nhofmeyr at>
Date:   Fri Dec 23 04:24:51 2016 +0100

    fsm: log calling file+line for error "event for NULL fi"
    Change-Id: I1970773440865f1415004bcf0164603468acf90b

commit b805cc19925b6815957ff470696887bfd74f2639
Author: Neels Hofmeyr <nhofmeyr at>
Date:   Fri Dec 23 04:23:18 2016 +0100

    fsm: doc: add missing file, line args; fix ws + tweak on one line
    Change-Id: I6af0d43ab0082e45df676c1d69b26310b59a8031

commit cba8eb9b21afd26ce65ef5098f6a178bce800bb7
Author: Neels Hofmeyr <nhofmeyr at>
Date:   Fri Dec 23 04:32:09 2016 +0100

    fsm_test.c: fix compiler warning: timer cb return type
    Change-Id: Ifd7e85cd69b5e7e473000abc1ef7a56748aafc0e


Summary of changes:
 include/osmocom/core/fsm.h | 26 ++++++++++++++
 src/fsm.c                  | 88 +++++++++++++++++++++++++++-------------------
 tests/fsm/fsm_test.c       |  2 +-
 3 files changed, 79 insertions(+), 37 deletions(-)

An utility library for Open Source Mobile Communications

More information about the osmocom-commitlog mailing list