[PATCH 0/4] take care of some coverity warnings

Neels Hofmeyr nhofmeyr at sysmocom.de
Fri Apr 15 21:01:04 UTC 2016


On Thu, Apr 14, 2016 at 09:37:52AM -0400, Holger Freyther wrote:
> 
> > On 14 Apr 2016, at 09:21, Neels Hofmeyr <nhofmeyr at sysmocom.de> wrote:
> > 
> > Fixing a few NULL dereference warnings found by the Iu coverity check.
> > They are not related apart from that.
> 
> I just looked at the gprs_gmm patch and stopped reading. Your commit message should at least have some of the context of coverity.
> 
> So when is llme NULL? Is it allowed to be NULL? Does it make sense? We don't want to blindly do these things but understand the code around and see if the tool is right or wrong. And if we disagree maybe change the flow of code or add an assert.

Spot on, I don't actually understand the llme one. All I know is that the
calling function gsm0408_rcv_gmm() has a condition "if (llme..." up at the top.
Let's drop that one unless someone else has the time to look at it.

The others I do understand though. Do read on ;)

~Neels

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.osmocom.org/pipermail/openbsc/attachments/20160415/e68f536d/attachment.bin>


More information about the OpenBSC mailing list