[PATCH 0/4] take care of some coverity warnings

Holger Freyther holger at freyther.de
Thu Apr 14 13:37:52 UTC 2016


> On 14 Apr 2016, at 09:21, Neels Hofmeyr <nhofmeyr at sysmocom.de> wrote:
> 
> Fixing a few NULL dereference warnings found by the Iu coverity check.
> They are not related apart from that.

I just looked at the gprs_gmm patch and stopped reading. Your commit message should at least have some of the context of coverity.

So when is llme NULL? Is it allowed to be NULL? Does it make sense? We don't want to blindly do these things but understand the code around and see if the tool is right or wrong. And if we disagree maybe change the flow of code or add an assert.

holger




More information about the OpenBSC mailing list