Potential bug in trx_if.c

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.

Andreas Eversberg andreas at eversberg.eu
Thu Jan 9 09:33:56 UTC 2014


Kurtis Heimerl wrote:
>  	/* if TSC is enabled only, the positive response is mandatory */
> -	return trx_ctrl_cmd(l1h, (setbsic_enabled) ? 0 : 1, "SETTSC", "%d",
>   
hi kurtis,

i think this is not a bug. in case we have "SETBSIC" enabled also, we do
not require a positive response for SETTSC. (and vice versa). the second
parameter of trx_ctrl_cmd() will be 0, which means that we accept a
negative response. this is because openbts transceivers require SETTSC
(and rejects SETBSIC) and calypso bts hack requires SETBSIC (and rejects
SETTSC).

regards,

andreas





More information about the OpenBSC mailing list