This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/OpenBSC@lists.osmocom.org/.
Kurtis Heimerl kheimerl at cs.berkeley.eduHey all, I've been working on getting the Range Networks RAD1 working with OsmoBTS. I *think* I've found a bug in trx_if.c. Basically, tsc checks the bsic variable and bsic checks the tsc variable. It *may* be intentional but I doubt that and I wanted to note it before I moved on. Patch is attached. Thanks! -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/openbsc/attachments/20140108/d90b9687/attachment.htm> -------------- next part -------------- diff --git a/src/osmo-bts-trx/trx_if.c b/src/osmo-bts-trx/trx_if.c index e798ca5..b00523a 100644 --- a/src/osmo-bts-trx/trx_if.c +++ b/src/osmo-bts-trx/trx_if.c @@ -235,7 +235,7 @@ int trx_if_cmd_settsc(struct trx_l1h *l1h, uint8_t tsc) if (!settsc_enabled) return 0; /* if TSC is enabled only, the positive response is mandatory */ - return trx_ctrl_cmd(l1h, (setbsic_enabled) ? 0 : 1, "SETTSC", "%d", + return trx_ctrl_cmd(l1h, (settsc_enabled) ? 0 : 1, "SETTSC", "%d", tsc); } @@ -244,7 +244,7 @@ int trx_if_cmd_setbsic(struct trx_l1h *l1h, uint8_t bsic) if (!setbsic_enabled) return 0; /* if BSIC is enabled only, the positive response is mandatory */ - return trx_ctrl_cmd(l1h, (settsc_enabled) ? 0 : 1, "SETBSIC", "%d", + return trx_ctrl_cmd(l1h, (setbsic_enabled) ? 0 : 1, "SETBSIC", "%d", bsic); }