Change in osmo-e1d[master]: Use the error counters for remote alarm + remote CRC error

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Sun Jan 2 12:03:35 UTC 2022


laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-e1d/+/26709 )


Change subject: Use the error counters for remote alarm + remote CRC error
......................................................................

Use the error counters for remote alarm + remote CRC error

Some time ago we added various error counters, but for two of them
we missed to actually ever increment them at all.

Change-Id: Ieb83a2e2e83e334c543bee83726f04f83b19227a
---
M src/mux_demux.c
1 file changed, 6 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-e1d refs/changes/09/26709/1

diff --git a/src/mux_demux.c b/src/mux_demux.c
index b0a9cf2..a588829 100644
--- a/src/mux_demux.c
+++ b/src/mux_demux.c
@@ -359,8 +359,10 @@
 
 		/* A bit is present in each odd frame */
 		if (frame_nr % 2) {
-			if (frame[0] & 0x20)
+			if (frame[0] & 0x20) {
 				line->ts0.cur_errmask |= E1L_TS0_RX_ALARM;
+				line_ctr_add(line, LINE_CTR_RX_REMOTE_A, 1);
+			}
 		}
 
 		/* E bits are present in frame 13 + 15 */
@@ -368,8 +370,10 @@
 			line->ts0.e_bits = frame[0] & 0x80 ? 2 : 0;
 		if (frame_nr == 15) {
 			line->ts0.e_bits |= frame[0] & 0x80 ? 1 : 0;
-			if (line->ts0.e_bits != 3)
+			if (line->ts0.e_bits != 3) {
 				line->ts0.cur_errmask |= E1L_TS0_RX_CRC4_ERR;
+				line_ctr_add(line, LINE_CTR_RX_REMOTE_E, 1);
+			}
 		}
 		/* cur_errmask is being cleared once per second via line->ts0.timer */
 	}

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/26709
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-e1d
Gerrit-Branch: master
Gerrit-Change-Id: Ieb83a2e2e83e334c543bee83726f04f83b19227a
Gerrit-Change-Number: 26709
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20220102/700f4c33/attachment.htm>


More information about the gerrit-log mailing list