<p>laforge has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-e1d/+/26709">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Use the error counters for remote alarm + remote CRC error<br><br>Some time ago we added various error counters, but for two of them<br>we missed to actually ever increment them at all.<br><br>Change-Id: Ieb83a2e2e83e334c543bee83726f04f83b19227a<br>---<br>M src/mux_demux.c<br>1 file changed, 6 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-e1d refs/changes/09/26709/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mux_demux.c b/src/mux_demux.c</span><br><span>index b0a9cf2..a588829 100644</span><br><span>--- a/src/mux_demux.c</span><br><span>+++ b/src/mux_demux.c</span><br><span>@@ -359,8 +359,10 @@</span><br><span> </span><br><span>          /* A bit is present in each odd frame */</span><br><span>             if (frame_nr % 2) {</span><br><span style="color: hsl(0, 100%, 40%);">-                     if (frame[0] & 0x20)</span><br><span style="color: hsl(120, 100%, 40%);">+                      if (frame[0] & 0x20) {</span><br><span>                           line->ts0.cur_errmask |= E1L_TS0_RX_ALARM;</span><br><span style="color: hsl(120, 100%, 40%);">+                         line_ctr_add(line, LINE_CTR_RX_REMOTE_A, 1);</span><br><span style="color: hsl(120, 100%, 40%);">+                  }</span><br><span>            }</span><br><span> </span><br><span>                /* E bits are present in frame 13 + 15 */</span><br><span>@@ -368,8 +370,10 @@</span><br><span>                     line->ts0.e_bits = frame[0] & 0x80 ? 2 : 0;</span><br><span>           if (frame_nr == 15) {</span><br><span>                        line->ts0.e_bits |= frame[0] & 0x80 ? 1 : 0;</span><br><span style="color: hsl(0, 100%, 40%);">-                     if (line->ts0.e_bits != 3)</span><br><span style="color: hsl(120, 100%, 40%);">+                 if (line->ts0.e_bits != 3) {</span><br><span>                              line->ts0.cur_errmask |= E1L_TS0_RX_CRC4_ERR;</span><br><span style="color: hsl(120, 100%, 40%);">+                              line_ctr_add(line, LINE_CTR_RX_REMOTE_E, 1);</span><br><span style="color: hsl(120, 100%, 40%);">+                  }</span><br><span>            }</span><br><span>            /* cur_errmask is being cleared once per second via line->ts0.timer */</span><br><span>    }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-e1d/+/26709">change 26709</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-e1d/+/26709"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-e1d </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ieb83a2e2e83e334c543bee83726f04f83b19227a </div>
<div style="display:none"> Gerrit-Change-Number: 26709 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>