This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Hoernchen gerrit-no-reply at lists.osmocom.orgHoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/25421 ) Change subject: libosmo-mgcp: cleanup audio codex alloc ...................................................................... Patch Set 5: (1 comment) https://gerrit.osmocom.org/c/osmo-mgw/+/25421/5/src/libosmo-mgcp/mgcp_sdp.c File src/libosmo-mgcp/mgcp_sdp.c: https://gerrit.osmocom.org/c/osmo-mgw/+/25421/5/src/libosmo-mgcp/mgcp_sdp.c@442 PS5, Line 442: strlen(rtp->codecs[i].subtype_name) ? rtp->codecs[i].subtype_name : "unknown"); > rtp->codecs[i].subtype_name[0] != '\0' ? rtp->codecs[i]. […] This is the kind of shit that makes our code hard to read and difficult to maintain, hand-optimized "smart" replacements instead of just calling the damn strlen function, if we at some point decide that strlen calls are a performance bottleneck AFTER PROFILING THE CODE we can still change this. By the way, we have a one-line function in a shared library that increments a rate counter (integer++) that can never be inlined due to being in a shared library. THAT is where performance suffers. Actually I'm gonna fix this right now... -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/25421 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Icc41643050a5e1ca3c66f307d60b6911ba1b8032 Gerrit-Change-Number: 25421 Gerrit-PatchSet: 5 Gerrit-Owner: Hoernchen <ewild at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Fri, 10 Sep 2021 13:08:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210910/56939e68/attachment.htm>