Change in osmo-mgw[master]: libosmo-mgcp: cleanup audio codex alloc

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Fri Sep 10 11:21:22 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/25421 )

Change subject: libosmo-mgcp: cleanup audio codex alloc
......................................................................


Patch Set 5: Code-Review+1

(3 comments)

https://gerrit.osmocom.org/c/osmo-mgw/+/25421/5/src/libosmo-mgcp/mgcp_codec.c 
File src/libosmo-mgcp/mgcp_codec.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/25421/5/src/libosmo-mgcp/mgcp_codec.c@179 
PS5, Line 179: 		strncpy(codec->audio_name, audio_name, sizeof(codec->audio_name));
osmo_strlcpy


https://gerrit.osmocom.org/c/osmo-mgw/+/25421/5/src/libosmo-mgcp/mgcp_codec.c@286 
PS5, Line 286: 	if (!strlen(codec->subtype_name))
if (codec->subtype_name[0] == '\0')


https://gerrit.osmocom.org/c/osmo-mgw/+/25421/5/src/libosmo-mgcp/mgcp_sdp.c 
File src/libosmo-mgcp/mgcp_sdp.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/25421/5/src/libosmo-mgcp/mgcp_sdp.c@442 
PS5, Line 442: 		      strlen(rtp->codecs[i].subtype_name) ? rtp->codecs[i].subtype_name : "unknown");
rtp->codecs[i].subtype_name[0] != '\0' ? rtp->codecs[i].subtype_name : "unknown"



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/25421
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: Icc41643050a5e1ca3c66f307d60b6911ba1b8032
Gerrit-Change-Number: 25421
Gerrit-PatchSet: 5
Gerrit-Owner: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Fri, 10 Sep 2021 11:21:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210910/61cfbe2b/attachment.htm>


More information about the gerrit-log mailing list