Change in osmo-hnodeb[master]: Use osmocom logging in non-main files

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

fixeria gerrit-no-reply at lists.osmocom.org
Fri Oct 29 05:40:48 UTC 2021


fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26017 )

Change subject: Use osmocom logging in non-main files
......................................................................


Patch Set 1: Code-Review-1

(14 comments)

Please revisit logging levels. Using INFO everywhere is not a good idea.

https://gerrit.osmocom.org/c/osmo-hnodeb/+/26017/1/src/osmo-hnodeb/debug.c 
File src/osmo-hnodeb/debug.c:

https://gerrit.osmocom.org/c/osmo-hnodeb/+/26017/1/src/osmo-hnodeb/debug.c@26 
PS1, Line 26: loglevel = LOGL_NOTICE
FYI: if 'loglevel' is not set explicitly, libosmocore itself would set it to LOGL_NOTICE.


https://gerrit.osmocom.org/c/osmo-hnodeb/+/26017/1/src/osmo-hnodeb/hnbap.c 
File src/osmo-hnodeb/hnbap.c:

https://gerrit.osmocom.org/c/osmo-hnodeb/+/26017/1/src/osmo-hnodeb/hnbap.c@65 
PS1, Line 65: LOGL_INFO
NOTICE/ERROR?


https://gerrit.osmocom.org/c/osmo-hnodeb/+/26017/1/src/osmo-hnodeb/hnbap.c@96 
PS1, Line 96: LOGL_INFO
NOTICE/ERROR?


https://gerrit.osmocom.org/c/osmo-hnodeb/+/26017/1/src/osmo-hnodeb/hnbap.c@186 
PS1, Line 186: LOGL_INFO
NOTICE/ERROR?


https://gerrit.osmocom.org/c/osmo-hnodeb/+/26017/1/src/osmo-hnodeb/hnbap.c@215 
PS1, Line 215: LOGL_INFO
NOTICE/ERROR?


https://gerrit.osmocom.org/c/osmo-hnodeb/+/26017/1/src/osmo-hnodeb/nas.c 
File src/osmo-hnodeb/nas.c:

https://gerrit.osmocom.org/c/osmo-hnodeb/+/26017/1/src/osmo-hnodeb/nas.c@90 
PS1, Line 90: LOGL_INFO
NOTICE/ERROR?


https://gerrit.osmocom.org/c/osmo-hnodeb/+/26017/1/src/osmo-hnodeb/nas.c@116 
PS1, Line 116: LOGL_INFO
NOTICE/ERROR?


https://gerrit.osmocom.org/c/osmo-hnodeb/+/26017/1/src/osmo-hnodeb/nas.c@161 
PS1, Line 161: LOGL_INFO
NOTICE/ERROR?


https://gerrit.osmocom.org/c/osmo-hnodeb/+/26017/1/src/osmo-hnodeb/nas.c@186 
PS1, Line 186: LOGL_INFO
DEBUG?


https://gerrit.osmocom.org/c/osmo-hnodeb/+/26017/1/src/osmo-hnodeb/nas.c@200 
PS1, Line 200: LOGL_INFO
NOTICE/ERROR?


https://gerrit.osmocom.org/c/osmo-hnodeb/+/26017/1/src/osmo-hnodeb/nas.c@234 
PS1, Line 234: LOGL_INFO
NOTICE/ERROR?


https://gerrit.osmocom.org/c/osmo-hnodeb/+/26017/1/src/osmo-hnodeb/nas.c@251 
PS1, Line 251: LOGL_INFO
NOTICE/ERROR?


https://gerrit.osmocom.org/c/osmo-hnodeb/+/26017/1/src/osmo-hnodeb/nas.c@261 
PS1, Line 261: LOGL_INFO
NOTICE/ERROR?


https://gerrit.osmocom.org/c/osmo-hnodeb/+/26017/1/src/osmo-hnodeb/nas.c@264 
PS1, Line 264: LOGL_INFO
NOTICE/ERROR?



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26017
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hnodeb
Gerrit-Branch: master
Gerrit-Change-Id: I649b17803aeffd20354aa76dde61094959f08e43
Gerrit-Change-Number: 26017
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Comment-Date: Fri, 29 Oct 2021 05:40:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211029/80252d48/attachment.htm>


More information about the gerrit-log mailing list