<p style="white-space: pre-wrap; word-wrap: break-word;">Please revisit logging levels. Using INFO everywhere is not a good idea.</p><p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4;">Code-Review -1</span></p><p><a href="https://gerrit.osmocom.org/c/osmo-hnodeb/+/26017">View Change</a></p><p>14 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-hnodeb/+/26017/1/src/osmo-hnodeb/debug.c">File src/osmo-hnodeb/debug.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-hnodeb/+/26017/1/src/osmo-hnodeb/debug.c@26">Patch Set #1, Line 26:</a> <code style="font-family:monospace,monospace">loglevel = LOGL_NOTICE</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">FYI: if 'loglevel' is not set explicitly, libosmocore itself would set it to LOGL_NOTICE.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-hnodeb/+/26017/1/src/osmo-hnodeb/hnbap.c">File src/osmo-hnodeb/hnbap.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-hnodeb/+/26017/1/src/osmo-hnodeb/hnbap.c@65">Patch Set #1, Line 65:</a> <code style="font-family:monospace,monospace">LOGL_INFO</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">NOTICE/ERROR?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-hnodeb/+/26017/1/src/osmo-hnodeb/hnbap.c@96">Patch Set #1, Line 96:</a> <code style="font-family:monospace,monospace">LOGL_INFO</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">NOTICE/ERROR?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-hnodeb/+/26017/1/src/osmo-hnodeb/hnbap.c@186">Patch Set #1, Line 186:</a> <code style="font-family:monospace,monospace">LOGL_INFO</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">NOTICE/ERROR?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-hnodeb/+/26017/1/src/osmo-hnodeb/hnbap.c@215">Patch Set #1, Line 215:</a> <code style="font-family:monospace,monospace">LOGL_INFO</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">NOTICE/ERROR?</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-hnodeb/+/26017/1/src/osmo-hnodeb/nas.c">File src/osmo-hnodeb/nas.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-hnodeb/+/26017/1/src/osmo-hnodeb/nas.c@90">Patch Set #1, Line 90:</a> <code style="font-family:monospace,monospace">LOGL_INFO</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">NOTICE/ERROR?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-hnodeb/+/26017/1/src/osmo-hnodeb/nas.c@116">Patch Set #1, Line 116:</a> <code style="font-family:monospace,monospace">LOGL_INFO</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">NOTICE/ERROR?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-hnodeb/+/26017/1/src/osmo-hnodeb/nas.c@161">Patch Set #1, Line 161:</a> <code style="font-family:monospace,monospace">LOGL_INFO</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">NOTICE/ERROR?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-hnodeb/+/26017/1/src/osmo-hnodeb/nas.c@186">Patch Set #1, Line 186:</a> <code style="font-family:monospace,monospace">LOGL_INFO</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">DEBUG?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-hnodeb/+/26017/1/src/osmo-hnodeb/nas.c@200">Patch Set #1, Line 200:</a> <code style="font-family:monospace,monospace">LOGL_INFO</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">NOTICE/ERROR?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-hnodeb/+/26017/1/src/osmo-hnodeb/nas.c@234">Patch Set #1, Line 234:</a> <code style="font-family:monospace,monospace">LOGL_INFO</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">NOTICE/ERROR?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-hnodeb/+/26017/1/src/osmo-hnodeb/nas.c@251">Patch Set #1, Line 251:</a> <code style="font-family:monospace,monospace">LOGL_INFO</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">NOTICE/ERROR?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-hnodeb/+/26017/1/src/osmo-hnodeb/nas.c@261">Patch Set #1, Line 261:</a> <code style="font-family:monospace,monospace">LOGL_INFO</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">NOTICE/ERROR?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-hnodeb/+/26017/1/src/osmo-hnodeb/nas.c@264">Patch Set #1, Line 264:</a> <code style="font-family:monospace,monospace">LOGL_INFO</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">NOTICE/ERROR?</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-hnodeb/+/26017">change 26017</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-hnodeb/+/26017"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-hnodeb </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I649b17803aeffd20354aa76dde61094959f08e43 </div>
<div style="display:none"> Gerrit-Change-Number: 26017 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 29 Oct 2021 05:40:48 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>