This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
laforge gerrit-no-reply at lists.osmocom.orglaforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/25962 ) Change subject: sccp: Add minimalistic support for XUDT / XUDTS ...................................................................... Patch Set 2: (3 comments) https://gerrit.osmocom.org/c/libosmo-sccp/+/25962/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/c/libosmo-sccp/+/25962/1//COMMIT_MSG@11 PS1, Line 11: a) because the sender wants to use segemntation > segmentation Done https://gerrit.osmocom.org/c/libosmo-sccp/+/25962/1/include/osmocom/sccp/sccp_types.h File include/osmocom/sccp/sccp_types.h: https://gerrit.osmocom.org/c/libosmo-sccp/+/25962/1/include/osmocom/sccp/sccp_types.h@482 PS1, Line 482: uint8_t optional_start; > should this be inside OPTIONAL define block below? I did it exactly like it is in the existing message definitions for other messages that have optional parts to ensure consistency in the file. The "OPTIONAL" blocks are actually some strange form of comments, as it would never compile if OPTIONAL would be true. https://gerrit.osmocom.org/c/libosmo-sccp/+/25962/1/src/sccp2sua.c File src/sccp2sua.c: https://gerrit.osmocom.org/c/libosmo-sccp/+/25962/1/src/sccp2sua.c@1203 PS1, Line 1203: static int sua_to_sccp_xudt(struct msgb *msg, struct xua_msg *xua); > Why simply not putting the entire function here? to ensure the systematic ordering of functions in the file, grouping code by logical functionality rather than by linking dependency. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/25962 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-sccp Gerrit-Branch: master Gerrit-Change-Id: Ic5b9486f1aeb4bb90cfe702a7ce996f5d82ded2c Gerrit-Change-Number: 25962 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge at osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin at sysmocom.de> Gerrit-Comment-Date: Tue, 26 Oct 2021 14:29:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211026/d93416f3/attachment.htm>