<p><a href="https://gerrit.osmocom.org/c/libosmo-sccp/+/25962">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/libosmo-sccp/+/25962/1//COMMIT_MSG">Commit Message:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmo-sccp/+/25962/1//COMMIT_MSG@11">Patch Set #1, Line 11:</a> <code style="font-family:monospace,monospace">a) because the sender wants to use segemntation</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">segmentation</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Done</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/libosmo-sccp/+/25962/1/include/osmocom/sccp/sccp_types.h">File include/osmocom/sccp/sccp_types.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmo-sccp/+/25962/1/include/osmocom/sccp/sccp_types.h@482">Patch Set #1, Line 482:</a> <code style="font-family:monospace,monospace">        uint8_t                 optional_start;</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">should this be inside OPTIONAL define block below?</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">I did it exactly like it is in the existing message definitions for other messages that have optional parts to ensure consistency in the file.</p><p style="white-space: pre-wrap; word-wrap: break-word;">The "OPTIONAL" blocks are actually some strange form of comments, as it would never compile if OPTIONAL would be true.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/libosmo-sccp/+/25962/1/src/sccp2sua.c">File src/sccp2sua.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/libosmo-sccp/+/25962/1/src/sccp2sua.c@1203">Patch Set #1, Line 1203:</a> <code style="font-family:monospace,monospace">static int sua_to_sccp_xudt(struct msgb *msg, struct xua_msg *xua);</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Why simply not putting the entire function here?</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">to ensure the systematic ordering of functions in the file, grouping code by logical functionality rather than by linking dependency.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmo-sccp/+/25962">change 25962</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmo-sccp/+/25962"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmo-sccp </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ic5b9486f1aeb4bb90cfe702a7ce996f5d82ded2c </div>
<div style="display:none"> Gerrit-Change-Number: 25962 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-CC: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 26 Oct 2021 14:29:15 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>