This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25813 ) Change subject: bts_rcv_rach(): Split code paths for Ass and Ass Rej ...................................................................... Patch Set 1: (2 comments) https://gerrit.osmocom.org/c/osmo-pcu/+/25813/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/c/osmo-pcu/+/25813/1//COMMIT_MSG@9 PS1, Line 9: a lot easier to follow > I would not say it's hard to follow the current variant of this function. […] I'm happy you find it's not hard to follow the function, but it is to me. It's not the first time I have to spend time looking at that function for a while to make sure everything is fine and not faulty, due to final path being shared with some parts of the code jumping (goto) into it with some varaibles not set, etc. Even gcc had problems tracking variable dependencies there. I think it's "generally" understood a good practice to avoid goto jumping to one place or another while it's a usual good practice to use them for error handling + return paths. https://gerrit.osmocom.org/c/osmo-pcu/+/25813/1/src/bts.cpp File src/bts.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/25813/1/src/bts.cpp@870 PS1, Line 870: struct gprs_rlcmac_pdch *pdch; > Unrelated change. It's not unrelated: Due to untangling the final path, I expect gcc being able to follow variable initialization properly now. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/25813 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I80e554315d36a515a7edc9ae51057ce31eb9110d Gerrit-Change-Number: 25813 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Comment-Date: Mon, 18 Oct 2021 13:35:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211018/c74f3ce3/attachment.htm>