This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
dexter gerrit-no-reply at lists.osmocom.orgdexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25813 ) Change subject: bts_rcv_rach(): Split code paths for Ass and Ass Rej ...................................................................... Patch Set 1: Code-Review+1 (2 comments) https://gerrit.osmocom.org/c/osmo-pcu/+/25813/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/c/osmo-pcu/+/25813/1//COMMIT_MSG@9 PS1, Line 9: a lot easier to follow > I'm happy you find it's not hard to follow the function, but it is to me. […] I have tried to read the section that was changed. I find it more readable how it is now. label "send_imm_ass_rej" suggests that the code is already at the point where it will sed the send_imm_ass_rej, but in the old version the first few lines after send_imm_ass_rej serve also the non reject case. This is very confusing. I think the new version makes more sense. https://gerrit.osmocom.org/c/osmo-pcu/+/25813/1/src/bts.cpp File src/bts.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/25813/1/src/bts.cpp@870 PS1, Line 870: struct gprs_rlcmac_pdch *pdch; > It's not unrelated: Due to untangling the final path, I expect gcc being able to follow variable ini […] Ack -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/25813 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I80e554315d36a515a7edc9ae51057ce31eb9110d Gerrit-Change-Number: 25813 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier at sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: osmith <osmith at sysmocom.de> Gerrit-Comment-Date: Mon, 18 Oct 2021 16:24:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin at sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211018/07f39c41/attachment.htm>