Change in osmo-pcu[master]: pdch: rcv_data_block: Avoid releasing ULC entry if expecting somethin...

[pespin]

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/25775 )

Change subject: pdch: rcv_data_block: Avoid releasing ULC entry if expecting something else on UL
......................................................................

pdch: rcv_data_block: Avoid releasing ULC entry if expecting something else on UL

Let's only release PDCH ULC entry if it was indeed what we expected.
In other case, time it out.

Change-Id: I1537587f5ee801c633784691b576ebb1ed521e95
---
M src/pdch.cpp
1 file changed, 3 insertions(+), 2 deletions(-)

Approvals:
  fixeria: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/pdch.cpp b/src/pdch.cpp
index ca3a0ea..68bc69d 100644
--- a/src/pdch.cpp
+++ b/src/pdch.cpp
@@ -982,7 +982,9 @@
 	if (node) {
 		switch (node->type) {
 		case PDCH_ULC_NODE_TBF_USF:
-			if (tbf != node->tbf_usf.ul_tbf)
+			if (tbf == node->tbf_usf.ul_tbf)
+				pdch_ulc_release_node(ulc, node);
+			else
 				LOGPDCH(this, DRLCMACUL, LOGL_NOTICE, "FN=%" PRIu32 " "
 					"Rx UL DATA from unexpected %s vs expected %s\n",
 					fn, tbf_name(tbf), tbf_name(node->tbf_usf.ul_tbf));
@@ -998,7 +1000,6 @@
 				fn, tbf_name(tbf));
 			break;
 		}
-		pdch_ulc_release_node(ulc, node);
 	} else {
 		LOGPDCH(this, DRLCMACUL, LOGL_NOTICE, "FN=%" PRIu32 " "
 			"Rx UL DATA from unexpected %s\n", fn, tbf_name(tbf));

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/25775
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I1537587f5ee801c633784691b576ebb1ed521e95
Gerrit-Change-Number: 25775
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211013/651a4946/attachment.htm>