<p>pespin <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-pcu/+/25775">View Change</a></p><div style="white-space:pre-wrap">Approvals:
fixeria: Looks good to me, approved
Jenkins Builder: Verified
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">pdch: rcv_data_block: Avoid releasing ULC entry if expecting something else on UL<br><br>Let's only release PDCH ULC entry if it was indeed what we expected.<br>In other case, time it out.<br><br>Change-Id: I1537587f5ee801c633784691b576ebb1ed521e95<br>---<br>M src/pdch.cpp<br>1 file changed, 3 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/pdch.cpp b/src/pdch.cpp</span><br><span>index ca3a0ea..68bc69d 100644</span><br><span>--- a/src/pdch.cpp</span><br><span>+++ b/src/pdch.cpp</span><br><span>@@ -982,7 +982,9 @@</span><br><span> if (node) {</span><br><span> switch (node->type) {</span><br><span> case PDCH_ULC_NODE_TBF_USF:</span><br><span style="color: hsl(0, 100%, 40%);">- if (tbf != node->tbf_usf.ul_tbf)</span><br><span style="color: hsl(120, 100%, 40%);">+ if (tbf == node->tbf_usf.ul_tbf)</span><br><span style="color: hsl(120, 100%, 40%);">+ pdch_ulc_release_node(ulc, node);</span><br><span style="color: hsl(120, 100%, 40%);">+ else</span><br><span> LOGPDCH(this, DRLCMACUL, LOGL_NOTICE, "FN=%" PRIu32 " "</span><br><span> "Rx UL DATA from unexpected %s vs expected %s\n",</span><br><span> fn, tbf_name(tbf), tbf_name(node->tbf_usf.ul_tbf));</span><br><span>@@ -998,7 +1000,6 @@</span><br><span> fn, tbf_name(tbf));</span><br><span> break;</span><br><span> }</span><br><span style="color: hsl(0, 100%, 40%);">- pdch_ulc_release_node(ulc, node);</span><br><span> } else {</span><br><span> LOGPDCH(this, DRLCMACUL, LOGL_NOTICE, "FN=%" PRIu32 " "</span><br><span> "Rx UL DATA from unexpected %s\n", fn, tbf_name(tbf));</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-pcu/+/25775">change 25775</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-pcu/+/25775"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-pcu </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I1537587f5ee801c633784691b576ebb1ed521e95 </div>
<div style="display:none"> Gerrit-Change-Number: 25775 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>