This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
fixeria gerrit-no-reply at lists.osmocom.orgfixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/25721 ) Change subject: l1sap: check if BTS model supports interference reporting ...................................................................... l1sap: check if BTS model supports interference reporting Currently, only osmo-bts-trx is capable of reporting the interference levels to L1SAP. Thus it does not make sense to trigger the averaging logic and send empty reports over the A-bis/RSL and the PCUIF. Change-Id: Ic17eb46bdca3c33ac4d6e560a093b635b75424a5 Related: SYS#5313 --- M include/osmo-bts/bts.h M src/common/l1sap.c M src/osmo-bts-trx/main.c 3 files changed, 5 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved laforge: Looks good to me, but someone else must approve diff --git a/include/osmo-bts/bts.h b/include/osmo-bts/bts.h index fab7f96..4683758 100644 --- a/include/osmo-bts/bts.h +++ b/include/osmo-bts/bts.h @@ -62,6 +62,8 @@ /* Whether the BTS model requires RadioCarrier MO to be in Enabled state * (OPSTARTed) before OPSTARTing the RadioChannel MOs. See OS#5157 */ #define BTS_INTERNAL_FLAG_NM_RCHANNEL_DEPENDS_RCARRIER (1 << 2) +/* Whether the BTS model reports interference measurements to L1SAP. */ +#define BTS_INTERNAL_FLAG_INTERF_MEAS (1 << 3) /* BTS implementation flags (internal use, not exposed via OML) */ #define bts_internal_flag_get(bts, flag) \ diff --git a/src/common/l1sap.c b/src/common/l1sap.c index 2b539d7..f5d2364 100644 --- a/src/common/l1sap.c +++ b/src/common/l1sap.c @@ -667,7 +667,8 @@ } /* Report interference levels to the BSC */ - l1sap_interf_meas_report(bts); + if (bts_internal_flag_get(bts, BTS_INTERNAL_FLAG_INTERF_MEAS)) + l1sap_interf_meas_report(bts); return 0; } diff --git a/src/osmo-bts-trx/main.c b/src/osmo-bts-trx/main.c index e31597b..5d680f0 100644 --- a/src/osmo-bts-trx/main.c +++ b/src/osmo-bts-trx/main.c @@ -151,6 +151,7 @@ osmo_bts_set_feature(bts->features, BTS_FEAT_ACCH_TEMP_OVP); bts_internal_flag_set(bts, BTS_INTERNAL_FLAG_MEAS_PAYLOAD_COMB); + bts_internal_flag_set(bts, BTS_INTERNAL_FLAG_INTERF_MEAS); return 0; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/25721 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ic17eb46bdca3c33ac4d6e560a093b635b75424a5 Gerrit-Change-Number: 25721 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: pespin <pespin at sysmocom.de> Gerrit-MessageType: merged -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211008/56445532/attachment.htm>