<p>fixeria <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/25721">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  pespin: Looks good to me, approved
  laforge: Looks good to me, but someone else must approve

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">l1sap: check if BTS model supports interference reporting<br><br>Currently, only osmo-bts-trx is capable of reporting the interference<br>levels to L1SAP.  Thus it does not make sense to trigger the averaging<br>logic and send empty reports over the A-bis/RSL and the PCUIF.<br><br>Change-Id: Ic17eb46bdca3c33ac4d6e560a093b635b75424a5<br>Related: SYS#5313<br>---<br>M include/osmo-bts/bts.h<br>M src/common/l1sap.c<br>M src/osmo-bts-trx/main.c<br>3 files changed, 5 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmo-bts/bts.h b/include/osmo-bts/bts.h</span><br><span>index fab7f96..4683758 100644</span><br><span>--- a/include/osmo-bts/bts.h</span><br><span>+++ b/include/osmo-bts/bts.h</span><br><span>@@ -62,6 +62,8 @@</span><br><span> /* Whether the BTS model requires RadioCarrier MO to be in Enabled state</span><br><span>  * (OPSTARTed) before OPSTARTing the RadioChannel MOs. See OS#5157 */</span><br><span> #define BTS_INTERNAL_FLAG_NM_RCHANNEL_DEPENDS_RCARRIER (1 << 2)</span><br><span style="color: hsl(120, 100%, 40%);">+/* Whether the BTS model reports interference measurements to L1SAP. */</span><br><span style="color: hsl(120, 100%, 40%);">+#define BTS_INTERNAL_FLAG_INTERF_MEAS                  (1 << 3)</span><br><span> </span><br><span> /* BTS implementation flags (internal use, not exposed via OML) */</span><br><span> #define bts_internal_flag_get(bts, flag) \</span><br><span>diff --git a/src/common/l1sap.c b/src/common/l1sap.c</span><br><span>index 2b539d7..f5d2364 100644</span><br><span>--- a/src/common/l1sap.c</span><br><span>+++ b/src/common/l1sap.c</span><br><span>@@ -667,7 +667,8 @@</span><br><span>    }</span><br><span> </span><br><span>        /* Report interference levels to the BSC */</span><br><span style="color: hsl(0, 100%, 40%);">-     l1sap_interf_meas_report(bts);</span><br><span style="color: hsl(120, 100%, 40%);">+        if (bts_internal_flag_get(bts, BTS_INTERNAL_FLAG_INTERF_MEAS))</span><br><span style="color: hsl(120, 100%, 40%);">+                l1sap_interf_meas_report(bts);</span><br><span> </span><br><span>   return 0;</span><br><span> }</span><br><span>diff --git a/src/osmo-bts-trx/main.c b/src/osmo-bts-trx/main.c</span><br><span>index e31597b..5d680f0 100644</span><br><span>--- a/src/osmo-bts-trx/main.c</span><br><span>+++ b/src/osmo-bts-trx/main.c</span><br><span>@@ -151,6 +151,7 @@</span><br><span>        osmo_bts_set_feature(bts->features, BTS_FEAT_ACCH_TEMP_OVP);</span><br><span> </span><br><span>  bts_internal_flag_set(bts, BTS_INTERNAL_FLAG_MEAS_PAYLOAD_COMB);</span><br><span style="color: hsl(120, 100%, 40%);">+      bts_internal_flag_set(bts, BTS_INTERNAL_FLAG_INTERF_MEAS);</span><br><span> </span><br><span>       return 0;</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/25721">change 25721</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/25721"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ic17eb46bdca3c33ac4d6e560a093b635b75424a5 </div>
<div style="display:none"> Gerrit-Change-Number: 25721 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>