Change in osmo-ccid-firmware[master]: sim slots: omit interrupt disabling for status polling

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Sat Nov 27 14:46:26 UTC 2021


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26395 )

Change subject: sim slots: omit interrupt disabling for status polling
......................................................................


Patch Set 3: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26395/3/sysmoOCTSIM/ncn8025.c 
File sysmoOCTSIM/ncn8025.c:

https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26395/3/sysmoOCTSIM/ncn8025.c@101 
PS3, Line 101: uint32_t pin_values = hri_port_read_IN_reg(PORT, GPIO_PORT(pin));
             : 
             : 	return (bool)(pin_values & (0x01U << GPIO_PIN(pin)));
might be worth to create an [inline?] function for this if we need it more often, something like __gpio_get_pin_level() if we want to use Linux customs for functios that bypass locking.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26395
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ccid-firmware
Gerrit-Branch: master
Gerrit-Change-Id: I8f32ad446438ef7776cc8a4aac1946f1a39a8ceb
Gerrit-Change-Number: 26395
Gerrit-PatchSet: 3
Gerrit-Owner: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Sat, 27 Nov 2021 14:46:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211127/b31ea322/attachment.htm>


More information about the gerrit-log mailing list