Change in osmo-ccid-firmware[master]: sim slots: omit interrupt disabling for status polling

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Hoernchen gerrit-no-reply at lists.osmocom.org
Sat Nov 27 14:55:59 UTC 2021


Hoernchen has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26395 )

Change subject: sim slots: omit interrupt disabling for status polling
......................................................................


Patch Set 3:

This  is a fairly unique function, because we know the pins we're interested in are configured for input, we don't care about intermittent pin state manipulation by interrupts, and the state changes are fairly slow. The atmel functions are mostly very generic and inefficient, there is already a few cycles delay for every port state access unless you run those in the high-power modes, and then there is a critical section wrapped around the atmel function because it uses multiple accesses to check per-pin direction and also gets the state for pins set to output, none of which is necessary here.


-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/26395
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ccid-firmware
Gerrit-Branch: master
Gerrit-Change-Id: I8f32ad446438ef7776cc8a4aac1946f1a39a8ceb
Gerrit-Change-Number: 26395
Gerrit-PatchSet: 3
Gerrit-Owner: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Comment-Date: Sat, 27 Nov 2021 14:55:59 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211127/ca22c9ed/attachment.htm>


More information about the gerrit-log mailing list