Change in osmo-mgw[master]: adjust mgcp response context

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Thu Nov 11 09:11:58 UTC 2021


laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/25447 )

Change subject: adjust mgcp response context
......................................................................


Patch Set 6:

(1 comment)

https://gerrit.osmocom.org/c/osmo-mgw/+/25447/6/src/libosmo-mgcp/mgcp_protocol.c 
File src/libosmo-mgcp/mgcp_protocol.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/25447/6/src/libosmo-mgcp/mgcp_protocol.c@187 
PS6, Line 187: 	msgb_reserve(msg, 128);
> Ah I see, so there's no msgb_alloc_headroom_c() I guess.
There is msgb_alloc_headroom_c() since 2019:

commit 179f35702ece13f4ab7fd1b331bef664834d8473
Author: Harald Welte <laforge at gnumonks.org>
Date:   Mon Mar 18 18:38:47 2019 +0100

So I would argue to use it.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/25447
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: Id17f51d8bc0d1ba26f7fca72b1679ffadc9d6dc8
Gerrit-Change-Number: 25447
Gerrit-PatchSet: 6
Gerrit-Owner: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Thu, 11 Nov 2021 09:11:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin at sysmocom.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211111/9d066eb3/attachment.htm>


More information about the gerrit-log mailing list