Change in osmo-mgw[master]: adjust mgcp response context

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

pespin gerrit-no-reply at lists.osmocom.org
Wed Nov 10 10:43:00 UTC 2021


pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/25447 )

Change subject: adjust mgcp response context
......................................................................


Patch Set 6: Code-Review+1

(2 comments)

https://gerrit.osmocom.org/c/osmo-mgw/+/25447/6/src/libosmo-mgcp/mgcp_protocol.c 
File src/libosmo-mgcp/mgcp_protocol.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/25447/6/src/libosmo-mgcp/mgcp_protocol.c@179 
PS6, Line 179: 	msg = msgb_alloc_c(ctx, 4096, "MGCP msg");
why is the headroom not needed anymore?


https://gerrit.osmocom.org/c/osmo-mgw/+/25447/6/src/libosmo-mgcp/mgcp_protocol.c@187 
PS6, Line 187: 	msgb_reserve(msg, 128);
Ah I see, so there's no msgb_alloc_headroom_c() I guess.



-- 
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/25447
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: Id17f51d8bc0d1ba26f7fca72b1679ffadc9d6dc8
Gerrit-Change-Number: 25447
Gerrit-PatchSet: 6
Gerrit-Owner: Hoernchen <ewild at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-Comment-Date: Wed, 10 Nov 2021 10:43:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211110/efa343e2/attachment.htm>


More information about the gerrit-log mailing list