This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/25940 ) Change subject: Properly handle dyn TS TCH with vamos after updating subslots_per_pchan ...................................................................... Patch Set 3: (1 comment) https://gerrit.osmocom.org/c/osmo-bsc/+/25940/3/src/osmo-bsc/timeslot_fsm.c File src/osmo-bsc/timeslot_fsm.c: https://gerrit.osmocom.org/c/osmo-bsc/+/25940/3/src/osmo-bsc/timeslot_fsm.c@216 PS3, Line 216: lchan = &ts->lchan[i]; > For dyn TS in TCH mode, the primary lchans are each shadowed by a VAMOS lchan […] pchan_is=GSM_PCHAN_TCH_F In this case we have: ts->max_primary_lchans = 1 max_lchans_possible_vamos = 2; ts->max_lchans_possible = 8; /*DYNTS*/ With previous code, the following happens: lchan[0].vamos.is_secondary = false lchan[1].vamos.is_secondary = true lchan[2].vamos.is_secondary = true lchan[3].vamos.is_secondary = true lchan[4].vamos.is_secondary = true lchan[5].vamos.is_secondary = true lchan[6].vamos.is_secondary = true lchan[7].vamos.is_secondary = true While with the new patch, the following should happen: lchan[0].vamos.is_secondary = false lchan[1].vamos.is_secondary = true lchan[2].vamos.is_secondary = false lchan[3].vamos.is_secondary = false lchan[4].vamos.is_secondary = false lchan[5].vamos.is_secondary = false lchan[6].vamos.is_secondary = false lchan[7].vamos.is_secondary = false -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/25940 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: If86af5fafe059d5e830c1f6d37034f7325d9a96c Gerrit-Change-Number: 25940 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de> Gerrit-Reviewer: laforge <laforge at osmocom.org> Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de> Gerrit-Reviewer: osmith <osmith at sysmocom.de> Gerrit-Comment-Date: Tue, 09 Nov 2021 10:38:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr at sysmocom.de> Gerrit-MessageType: comment -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211109/4905d7ce/attachment.htm>