<p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/25940">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/25940/3/src/osmo-bsc/timeslot_fsm.c">File src/osmo-bsc/timeslot_fsm.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/25940/3/src/osmo-bsc/timeslot_fsm.c@216">Patch Set #3, Line 216:</a> <code style="font-family:monospace,monospace">                   lchan = &ts->lchan[i];</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">For dyn TS in TCH mode, the primary lchans are each shadowed by a VAMOS lchan […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">pchan_is=GSM_PCHAN_TCH_F In this case we have:<br>ts->max_primary_lchans = 1<br>max_lchans_possible_vamos = 2;<br>ts->max_lchans_possible = 8; /*DYNTS*/</p><p style="white-space: pre-wrap; word-wrap: break-word;">With previous code, the following happens:<br>lchan[0].vamos.is_secondary = false<br>lchan[1].vamos.is_secondary = true<br>lchan[2].vamos.is_secondary = true<br>lchan[3].vamos.is_secondary = true<br>lchan[4].vamos.is_secondary = true<br>lchan[5].vamos.is_secondary = true<br>lchan[6].vamos.is_secondary = true<br>lchan[7].vamos.is_secondary = true</p><p style="white-space: pre-wrap; word-wrap: break-word;"><br>While with the new patch, the following should happen:<br>lchan[0].vamos.is_secondary = false<br>lchan[1].vamos.is_secondary = true<br>lchan[2].vamos.is_secondary = false<br>lchan[3].vamos.is_secondary = false<br>lchan[4].vamos.is_secondary = false<br>lchan[5].vamos.is_secondary = false<br>lchan[6].vamos.is_secondary = false<br>lchan[7].vamos.is_secondary = false</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/25940">change 25940</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/25940"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: If86af5fafe059d5e830c1f6d37034f7325d9a96c </div>
<div style="display:none"> Gerrit-Change-Number: 25940 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 09 Nov 2021 10:38:23 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>