This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
osmith gerrit-no-reply at lists.osmocom.orgosmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/26172 ) Change subject: lint: checkpatch_osmo: ignore TRAILING_STATEMENTS ...................................................................... lint: checkpatch_osmo: ignore TRAILING_STATEMENTS In Osmocom core, we have the following written in one line: while (osmo_select_main_ctx(1) > 0); This currently causes the following linter error: ERROR:TRAILING_STATEMENTS: trailing statements should be on next line According to the linter, we should write it as follows: while (osmo_select_main_ctx(1) > 0) ; But this is not followed in Osmocom code, so let's ignore the check. Related: OS#5087 Change-Id: Iaffe979b771c97c77edaf4aa0d232cb8939d1279 --- M lint/checkpatch/checkpatch_osmo.sh 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/72/26172/1 diff --git a/lint/checkpatch/checkpatch_osmo.sh b/lint/checkpatch/checkpatch_osmo.sh index f9cc74f..ec9384c 100755 --- a/lint/checkpatch/checkpatch_osmo.sh +++ b/lint/checkpatch/checkpatch_osmo.sh @@ -69,6 +69,7 @@ # * SPDX_LICENSE_TAG: we don't place it on line 1 # * SPLIT_STRING: we do split long messages over multiple lines # * STRING_FRAGMENTS: sometimes used intentionally to improve readability +# * TRAILING_STATEMENTS: not followed, e.g. 'while (osmo_select_main_ctx(1) > 0);' is put in one line # * UNNECESSARY_INT: not followed (see https://gerrit.osmocom.org/c/libosmocore/+/25345) # * UNSPECIFIED_INT: not followed (doesn't seem useful for us) @@ -103,6 +104,7 @@ --ignore SPDX_LICENSE_TAG \ --ignore SPLIT_STRING \ --ignore STRING_FRAGMENTS \ + --ignore TRAILING_STATEMENTS \ --ignore UNNECESSARY_INT \ --ignore UNSPECIFIED_INT \ --max-line-length 120 \ -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/26172 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Iaffe979b771c97c77edaf4aa0d232cb8939d1279 Gerrit-Change-Number: 26172 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith at sysmocom.de> Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211109/f65ce2d1/attachment.htm>