<p>osmith has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ci/+/26172">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">lint: checkpatch_osmo: ignore TRAILING_STATEMENTS<br><br>In Osmocom core, we have the following written in one line:<br>  while (osmo_select_main_ctx(1) > 0);<br><br>This currently causes the following linter error:<br>  ERROR:TRAILING_STATEMENTS: trailing statements should be on next line<br><br>According to the linter, we should write it as follows:<br>  while (osmo_select_main_ctx(1) > 0)<br>        ;<br><br>But this is not followed in Osmocom code, so let's ignore the check.<br><br>Related: OS#5087<br>Change-Id: Iaffe979b771c97c77edaf4aa0d232cb8939d1279<br>---<br>M lint/checkpatch/checkpatch_osmo.sh<br>1 file changed, 2 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/72/26172/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/lint/checkpatch/checkpatch_osmo.sh b/lint/checkpatch/checkpatch_osmo.sh</span><br><span>index f9cc74f..ec9384c 100755</span><br><span>--- a/lint/checkpatch/checkpatch_osmo.sh</span><br><span>+++ b/lint/checkpatch/checkpatch_osmo.sh</span><br><span>@@ -69,6 +69,7 @@</span><br><span> # * SPDX_LICENSE_TAG: we don't place it on line 1</span><br><span> # * SPLIT_STRING: we do split long messages over multiple lines</span><br><span> # * STRING_FRAGMENTS: sometimes used intentionally to improve readability</span><br><span style="color: hsl(120, 100%, 40%);">+# * TRAILING_STATEMENTS: not followed, e.g. 'while (osmo_select_main_ctx(1) > 0);' is put in one line</span><br><span> # * UNNECESSARY_INT: not followed (see https://gerrit.osmocom.org/c/libosmocore/+/25345)</span><br><span> # * UNSPECIFIED_INT: not followed (doesn't seem useful for us)</span><br><span> </span><br><span>@@ -103,6 +104,7 @@</span><br><span>  --ignore SPDX_LICENSE_TAG \</span><br><span>  --ignore SPLIT_STRING \</span><br><span>      --ignore STRING_FRAGMENTS \</span><br><span style="color: hsl(120, 100%, 40%);">+   --ignore TRAILING_STATEMENTS \</span><br><span>       --ignore UNNECESSARY_INT \</span><br><span>   --ignore UNSPECIFIED_INT \</span><br><span>   --max-line-length 120 \</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ci/+/26172">change 26172</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ci/+/26172"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ci </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Iaffe979b771c97c77edaf4aa0d232cb8939d1279 </div>
<div style="display:none"> Gerrit-Change-Number: 26172 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>