Change in osmo-pcu[master]: Add counter for successful contention resolution procedures

[laforge]

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26080 )

Change subject: Add counter for successful contention resolution procedures
......................................................................

Add counter for successful contention resolution procedures

This counter is related to succPDTCHSeizures,
(3GPP TS 52.402 B.2.1.51 Successful PDTCH seizures).

The relevant event when the first RLC block on the PDCH from the MS is
received is the fact that contention resolution is considered as done in
the network side. Hence, name the counter that way to ease
interpretation.

Related: SYS#4878
Change-Id: I3d67e3e68907921b43f2ca4398ad9578c0b2618c
---
M src/bts.cpp
M src/bts.h
M src/pdch.cpp
M src/tbf_ul.cpp
4 files changed, 6 insertions(+), 0 deletions(-)

Approvals:
  laforge: Looks good to me, but someone else must approve
  neels: Looks good to me, but someone else must approve
  fixeria: Looks good to me, but someone else must approve
  pespin: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/bts.cpp b/src/bts.cpp
index d053396..2dc8ffb 100644
--- a/src/bts.cpp
+++ b/src/bts.cpp
@@ -147,6 +147,7 @@
 	{ "immediate:assignment_UL",	"Immediate Assign UL  "},
 	{ "immediate:assignment_ul:one_phase",	"Immediate Assign UL (one phase packet access)"}, /* TS 52.402 B.2.1.50 */
 	{ "immediate:assignment_ul:two_phase",	"Immediate Assign UL (two phase packet access)"}, /* TS 52.402 B.2.1.50 */
+	{ "immediate:assignment_ul:contention_resolution_success", "First RLC Block (PDU) on the PDTCH from the MS received"}, /* TS 52.402 B.2.1.51 */
 	{ "immediate:assignment_rej",   "Immediate Assign Rej "},
 	{ "immediate:assignment_DL",	"Immediate Assign DL  "},
 	{ "channel:request_description","Channel Request Desc "},
diff --git a/src/bts.h b/src/bts.h
index d0119b6..3f482c9 100644
--- a/src/bts.h
+++ b/src/bts.h
@@ -139,6 +139,7 @@
 	CTR_IMMEDIATE_ASSIGN_UL_TBF,
 	CTR_IMMEDIATE_ASSIGN_UL_TBF_ONE_PHASE,
 	CTR_IMMEDIATE_ASSIGN_UL_TBF_TWO_PHASE,
+	CTR_IMMEDIATE_ASSIGN_UL_TBF_CONTENTION_RESOLUTION_SUCCESS,
 	CTR_IMMEDIATE_ASSIGN_REJ,
 	CTR_IMMEDIATE_ASSIGN_DL_TBF,
 	CTR_CHANNEL_REQUEST_DESCRIPTION,
diff --git a/src/pdch.cpp b/src/pdch.cpp
index a69ce60..fdac100 100644
--- a/src/pdch.cpp
+++ b/src/pdch.cpp
@@ -650,6 +650,8 @@
 				"MS requests UL TBF throguh SBA\n", fn);
 			ms_set_ta(ms, sba->ta);
 			sba_free(sba);
+			/* MS seized the PDCH answering on the SBA: */
+			bts_do_rate_ctr_inc(bts, CTR_IMMEDIATE_ASSIGN_UL_TBF_CONTENTION_RESOLUTION_SUCCESS);
 			break;
 		case PDCH_ULC_NODE_TBF_POLL:
 			if (item->tbf_poll.poll_tbf->direction != GPRS_RLCMAC_UL_TBF) {
diff --git a/src/tbf_ul.cpp b/src/tbf_ul.cpp
index 9390fbb..1d06e53 100644
--- a/src/tbf_ul.cpp
+++ b/src/tbf_ul.cpp
@@ -332,6 +332,8 @@
 	/* now we must set this flag, so we are allowed to assign downlink
 	 * TBF on PACCH. it is only allowed when TLLI is acknowledged. */
 	m_contention_resolution_done = 1;
+
+	bts_do_rate_ctr_inc(bts, CTR_IMMEDIATE_ASSIGN_UL_TBF_CONTENTION_RESOLUTION_SUCCESS);
 }
 
 /*! \brief receive data from PDCH/L1 */

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26080
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I3d67e3e68907921b43f2ca4398ad9578c0b2618c
Gerrit-Change-Number: 26080
Gerrit-PatchSet: 5
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211108/58ca47a5/attachment.htm>