<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-pcu/+/26080">View Change</a></p><div style="white-space:pre-wrap">Approvals:
laforge: Looks good to me, but someone else must approve
neels: Looks good to me, but someone else must approve
fixeria: Looks good to me, but someone else must approve
pespin: Looks good to me, approved
Jenkins Builder: Verified
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Add counter for successful contention resolution procedures<br><br>This counter is related to succPDTCHSeizures,<br>(3GPP TS 52.402 B.2.1.51 Successful PDTCH seizures).<br><br>The relevant event when the first RLC block on the PDCH from the MS is<br>received is the fact that contention resolution is considered as done in<br>the network side. Hence, name the counter that way to ease<br>interpretation.<br><br>Related: SYS#4878<br>Change-Id: I3d67e3e68907921b43f2ca4398ad9578c0b2618c<br>---<br>M src/bts.cpp<br>M src/bts.h<br>M src/pdch.cpp<br>M src/tbf_ul.cpp<br>4 files changed, 6 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/bts.cpp b/src/bts.cpp</span><br><span>index d053396..2dc8ffb 100644</span><br><span>--- a/src/bts.cpp</span><br><span>+++ b/src/bts.cpp</span><br><span>@@ -147,6 +147,7 @@</span><br><span> { "immediate:assignment_UL", "Immediate Assign UL "},</span><br><span> { "immediate:assignment_ul:one_phase", "Immediate Assign UL (one phase packet access)"}, /* TS 52.402 B.2.1.50 */</span><br><span> { "immediate:assignment_ul:two_phase", "Immediate Assign UL (two phase packet access)"}, /* TS 52.402 B.2.1.50 */</span><br><span style="color: hsl(120, 100%, 40%);">+ { "immediate:assignment_ul:contention_resolution_success", "First RLC Block (PDU) on the PDTCH from the MS received"}, /* TS 52.402 B.2.1.51 */</span><br><span> { "immediate:assignment_rej", "Immediate Assign Rej "},</span><br><span> { "immediate:assignment_DL", "Immediate Assign DL "},</span><br><span> { "channel:request_description","Channel Request Desc "},</span><br><span>diff --git a/src/bts.h b/src/bts.h</span><br><span>index d0119b6..3f482c9 100644</span><br><span>--- a/src/bts.h</span><br><span>+++ b/src/bts.h</span><br><span>@@ -139,6 +139,7 @@</span><br><span> CTR_IMMEDIATE_ASSIGN_UL_TBF,</span><br><span> CTR_IMMEDIATE_ASSIGN_UL_TBF_ONE_PHASE,</span><br><span> CTR_IMMEDIATE_ASSIGN_UL_TBF_TWO_PHASE,</span><br><span style="color: hsl(120, 100%, 40%);">+ CTR_IMMEDIATE_ASSIGN_UL_TBF_CONTENTION_RESOLUTION_SUCCESS,</span><br><span> CTR_IMMEDIATE_ASSIGN_REJ,</span><br><span> CTR_IMMEDIATE_ASSIGN_DL_TBF,</span><br><span> CTR_CHANNEL_REQUEST_DESCRIPTION,</span><br><span>diff --git a/src/pdch.cpp b/src/pdch.cpp</span><br><span>index a69ce60..fdac100 100644</span><br><span>--- a/src/pdch.cpp</span><br><span>+++ b/src/pdch.cpp</span><br><span>@@ -650,6 +650,8 @@</span><br><span> "MS requests UL TBF throguh SBA\n", fn);</span><br><span> ms_set_ta(ms, sba->ta);</span><br><span> sba_free(sba);</span><br><span style="color: hsl(120, 100%, 40%);">+ /* MS seized the PDCH answering on the SBA: */</span><br><span style="color: hsl(120, 100%, 40%);">+ bts_do_rate_ctr_inc(bts, CTR_IMMEDIATE_ASSIGN_UL_TBF_CONTENTION_RESOLUTION_SUCCESS);</span><br><span> break;</span><br><span> case PDCH_ULC_NODE_TBF_POLL:</span><br><span> if (item->tbf_poll.poll_tbf->direction != GPRS_RLCMAC_UL_TBF) {</span><br><span>diff --git a/src/tbf_ul.cpp b/src/tbf_ul.cpp</span><br><span>index 9390fbb..1d06e53 100644</span><br><span>--- a/src/tbf_ul.cpp</span><br><span>+++ b/src/tbf_ul.cpp</span><br><span>@@ -332,6 +332,8 @@</span><br><span> /* now we must set this flag, so we are allowed to assign downlink</span><br><span> * TBF on PACCH. it is only allowed when TLLI is acknowledged. */</span><br><span> m_contention_resolution_done = 1;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ bts_do_rate_ctr_inc(bts, CTR_IMMEDIATE_ASSIGN_UL_TBF_CONTENTION_RESOLUTION_SUCCESS);</span><br><span> }</span><br><span> </span><br><span> /*! \brief receive data from PDCH/L1 */</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-pcu/+/26080">change 26080</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-pcu/+/26080"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-pcu </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I3d67e3e68907921b43f2ca4398ad9578c0b2618c </div>
<div style="display:none"> Gerrit-Change-Number: 26080 </div>
<div style="display:none"> Gerrit-PatchSet: 5 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>