This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pespin gerrit-no-reply at lists.osmocom.orgpespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/26154 ) Change subject: tbf_ul: Set first_(common_)ts in handle_tbf_reject ...................................................................... tbf_ul: Set first_(common_)ts in handle_tbf_reject Let's set them to match expectancies for this type of dummy TBFs, in order to avoid acidental use/access of other timeslots to the one where the reject was associated to. Also use tbf_assign_control_ts() to log the TS used for the TBF, similar to what's used in other places where control_ts is assigned. Related: OS#5293 Change-Id: I32dcb29ad24519082b8665921efcce0b5a16d12e --- M src/tbf_ul.cpp M tests/tbf/TbfTest.err 2 files changed, 6 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/54/26154/1 diff --git a/src/tbf_ul.cpp b/src/tbf_ul.cpp index d6936e1..ca929ea 100644 --- a/src/tbf_ul.cpp +++ b/src/tbf_ul.cpp @@ -204,8 +204,11 @@ talloc_set_destructor(ul_tbf, ul_tbf_dtor); new (ul_tbf) gprs_rlcmac_ul_tbf(bts, ms); - ul_tbf->control_ts = ts; ul_tbf->trx = trx; + /* The only one TS is the common, control TS */ + ul_tbf->first_ts = ts; + ul_tbf->first_common_ts = ts; + tbf_assign_control_ts(ul_tbf); ul_tbf->m_ctrs = rate_ctr_group_alloc(ul_tbf, &tbf_ctrg_desc, next_tbf_ctr_group_id++); ul_tbf->m_ul_egprs_ctrs = rate_ctr_group_alloc(ul_tbf, &tbf_ul_egprs_ctrg_desc, diff --git a/tests/tbf/TbfTest.err b/tests/tbf/TbfTest.err index a8fd741..0374f57 100644 --- a/tests/tbf/TbfTest.err +++ b/tests/tbf/TbfTest.err @@ -9076,6 +9076,7 @@ UL_ASS_TBF{NONE}: Allocated DL_ASS_TBF{NONE}: Allocated UL_ACK_TBF{NONE}: Allocated +TBF(TFI=0 TLLI=0xffeeddd3 DIR=UL STATE=NEW) Setting Control TS 7 MS(TLLI=0xffeeddd3, IMSI=, TA=7, 11/11,) Attaching UL TBF: TBF(TFI=0 TLLI=0xffeeddd3 DIR=UL STATE=NEW) TBF{NEW}: Received Event ASSIGN_ADD_PACCH TBF(TFI=0 TLLI=0xffeeddd3 DIR=UL STATE=NEW) set ass. type PACCH [prev CCCH:0, PACCH:0] @@ -9106,6 +9107,7 @@ UL_ASS_TBF{NONE}: Allocated DL_ASS_TBF{NONE}: Allocated UL_ACK_TBF{NONE}: Allocated +TBF(TFI=0 TLLI=0xffeeddcc DIR=UL STATE=NEW) Setting Control TS 7 MS(TLLI=0xffeeddcc, IMSI=, TA=220, 0/0,) Attaching UL TBF: TBF(TFI=0 TLLI=0xffeeddcc DIR=UL STATE=NEW) TBF{NEW}: Received Event ASSIGN_ADD_PACCH TBF(TFI=0 TLLI=0xffeeddcc DIR=UL STATE=NEW) set ass. type PACCH [prev CCCH:0, PACCH:0] -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/26154 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I32dcb29ad24519082b8665921efcce0b5a16d12e Gerrit-Change-Number: 26154 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin at sysmocom.de> Gerrit-MessageType: newchange -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211108/b1f39d2b/attachment.htm>