<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-pcu/+/26154">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">tbf_ul: Set first_(common_)ts in handle_tbf_reject<br><br>Let's set them to match expectancies for this type of dummy TBFs, in<br>order to avoid acidental use/access of other timeslots to the one where<br>the reject was associated to.<br><br>Also use tbf_assign_control_ts() to log the TS used for the TBF, similar<br>to what's used in other places where control_ts is assigned.<br><br>Related: OS#5293<br>Change-Id: I32dcb29ad24519082b8665921efcce0b5a16d12e<br>---<br>M src/tbf_ul.cpp<br>M tests/tbf/TbfTest.err<br>2 files changed, 6 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/54/26154/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/tbf_ul.cpp b/src/tbf_ul.cpp</span><br><span>index d6936e1..ca929ea 100644</span><br><span>--- a/src/tbf_ul.cpp</span><br><span>+++ b/src/tbf_ul.cpp</span><br><span>@@ -204,8 +204,11 @@</span><br><span>        talloc_set_destructor(ul_tbf, ul_tbf_dtor);</span><br><span>  new (ul_tbf) gprs_rlcmac_ul_tbf(bts, ms);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   ul_tbf->control_ts = ts;</span><br><span>  ul_tbf->trx = trx;</span><br><span style="color: hsl(120, 100%, 40%);">+ /* The only one TS is the common, control TS */</span><br><span style="color: hsl(120, 100%, 40%);">+       ul_tbf->first_ts = ts;</span><br><span style="color: hsl(120, 100%, 40%);">+     ul_tbf->first_common_ts = ts;</span><br><span style="color: hsl(120, 100%, 40%);">+      tbf_assign_control_ts(ul_tbf);</span><br><span>       ul_tbf->m_ctrs = rate_ctr_group_alloc(ul_tbf, &tbf_ctrg_desc, next_tbf_ctr_group_id++);</span><br><span>       ul_tbf->m_ul_egprs_ctrs = rate_ctr_group_alloc(ul_tbf,</span><br><span>                                                   &tbf_ul_egprs_ctrg_desc,</span><br><span>diff --git a/tests/tbf/TbfTest.err b/tests/tbf/TbfTest.err</span><br><span>index a8fd741..0374f57 100644</span><br><span>--- a/tests/tbf/TbfTest.err</span><br><span>+++ b/tests/tbf/TbfTest.err</span><br><span>@@ -9076,6 +9076,7 @@</span><br><span> UL_ASS_TBF{NONE}: Allocated</span><br><span> DL_ASS_TBF{NONE}: Allocated</span><br><span> UL_ACK_TBF{NONE}: Allocated</span><br><span style="color: hsl(120, 100%, 40%);">+TBF(TFI=0 TLLI=0xffeeddd3 DIR=UL STATE=NEW) Setting Control TS 7</span><br><span> MS(TLLI=0xffeeddd3, IMSI=, TA=7, 11/11,) Attaching UL TBF: TBF(TFI=0 TLLI=0xffeeddd3 DIR=UL STATE=NEW)</span><br><span> TBF{NEW}: Received Event ASSIGN_ADD_PACCH</span><br><span> TBF(TFI=0 TLLI=0xffeeddd3 DIR=UL STATE=NEW) set ass. type PACCH [prev CCCH:0, PACCH:0]</span><br><span>@@ -9106,6 +9107,7 @@</span><br><span> UL_ASS_TBF{NONE}: Allocated</span><br><span> DL_ASS_TBF{NONE}: Allocated</span><br><span> UL_ACK_TBF{NONE}: Allocated</span><br><span style="color: hsl(120, 100%, 40%);">+TBF(TFI=0 TLLI=0xffeeddcc DIR=UL STATE=NEW) Setting Control TS 7</span><br><span> MS(TLLI=0xffeeddcc, IMSI=, TA=220, 0/0,) Attaching UL TBF: TBF(TFI=0 TLLI=0xffeeddcc DIR=UL STATE=NEW)</span><br><span> TBF{NEW}: Received Event ASSIGN_ADD_PACCH</span><br><span> TBF(TFI=0 TLLI=0xffeeddcc DIR=UL STATE=NEW) set ass. type PACCH [prev CCCH:0, PACCH:0]</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-pcu/+/26154">change 26154</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-pcu/+/26154"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-pcu </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I32dcb29ad24519082b8665921efcce0b5a16d12e </div>
<div style="display:none"> Gerrit-Change-Number: 26154 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>