Change in osmo-hnodeb[master]: hnb.c: Fix memleak in hnb_iuh_read_cb

[pespin]

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-hnodeb/+/26032 )

Change subject: hnb.c: Fix memleak in hnb_iuh_read_cb
......................................................................

hnb.c: Fix memleak in hnb_iuh_read_cb

Port from osmo-iuh.git Change-Id I6ecbce6aab11e1382ff9f71d901e1c6ac145f835.

Change-Id: If5d5d41693e26f485aa5372129dccf0dcfb7fa6c
---
M src/osmo-hnodeb/hnb.c
1 file changed, 6 insertions(+), 4 deletions(-)

Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved
  fixeria: Looks good to me, but someone else must approve



diff --git a/src/osmo-hnodeb/hnb.c b/src/osmo-hnodeb/hnb.c
index 34ff426..420095d 100644
--- a/src/osmo-hnodeb/hnb.c
+++ b/src/osmo-hnodeb/hnb.c
@@ -54,19 +54,20 @@
 		LOGP(DMAIN, LOGL_ERROR, "Error during sctp_recvmsg()\n");
 		/* FIXME: clean up after disappeared HNB */
 		osmo_stream_cli_close(conn);
-		return rc;
+		goto free_ret;
 	} else if (rc == 0) {
 		LOGP(DMAIN, LOGL_INFO, "Connection to HNB closed\n");
 		osmo_stream_cli_close(conn);
-		return -1;
+		rc = -1;
+		goto free_ret;
 	} else {
 		msgb_put(msg, rc);
 	}
 
 	if (flags & MSG_NOTIFICATION) {
 		LOGP(DMAIN, LOGL_DEBUG, "Ignoring SCTP notification\n");
-		msgb_free(msg);
-		return 0;
+		rc = 0;
+		goto free_ret;
 	}
 
 	sinfo.sinfo_ppid = ntohl(sinfo.sinfo_ppid);
@@ -94,6 +95,7 @@
 		break;
 	}
 
+free_ret:
 	msgb_free(msg);
 	return rc;
 }

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-hnodeb/+/26032
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hnodeb
Gerrit-Branch: master
Gerrit-Change-Id: If5d5d41693e26f485aa5372129dccf0dcfb7fa6c
Gerrit-Change-Number: 26032
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20211102/0ed1f14d/attachment.htm>