<p>pespin <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-hnodeb/+/26032">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved
  fixeria: Looks good to me, but someone else must approve

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">hnb.c: Fix memleak in hnb_iuh_read_cb<br><br>Port from osmo-iuh.git Change-Id I6ecbce6aab11e1382ff9f71d901e1c6ac145f835.<br><br>Change-Id: If5d5d41693e26f485aa5372129dccf0dcfb7fa6c<br>---<br>M src/osmo-hnodeb/hnb.c<br>1 file changed, 6 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/osmo-hnodeb/hnb.c b/src/osmo-hnodeb/hnb.c</span><br><span>index 34ff426..420095d 100644</span><br><span>--- a/src/osmo-hnodeb/hnb.c</span><br><span>+++ b/src/osmo-hnodeb/hnb.c</span><br><span>@@ -54,19 +54,20 @@</span><br><span>          LOGP(DMAIN, LOGL_ERROR, "Error during sctp_recvmsg()\n");</span><br><span>          /* FIXME: clean up after disappeared HNB */</span><br><span>          osmo_stream_cli_close(conn);</span><br><span style="color: hsl(0, 100%, 40%);">-            return rc;</span><br><span style="color: hsl(120, 100%, 40%);">+            goto free_ret;</span><br><span>       } else if (rc == 0) {</span><br><span>                LOGP(DMAIN, LOGL_INFO, "Connection to HNB closed\n");</span><br><span>              osmo_stream_cli_close(conn);</span><br><span style="color: hsl(0, 100%, 40%);">-            return -1;</span><br><span style="color: hsl(120, 100%, 40%);">+            rc = -1;</span><br><span style="color: hsl(120, 100%, 40%);">+              goto free_ret;</span><br><span>       } else {</span><br><span>             msgb_put(msg, rc);</span><br><span>   }</span><br><span> </span><br><span>        if (flags & MSG_NOTIFICATION) {</span><br><span>          LOGP(DMAIN, LOGL_DEBUG, "Ignoring SCTP notification\n");</span><br><span style="color: hsl(0, 100%, 40%);">-              msgb_free(msg);</span><br><span style="color: hsl(0, 100%, 40%);">-         return 0;</span><br><span style="color: hsl(120, 100%, 40%);">+             rc = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+               goto free_ret;</span><br><span>       }</span><br><span> </span><br><span>        sinfo.sinfo_ppid = ntohl(sinfo.sinfo_ppid);</span><br><span>@@ -94,6 +95,7 @@</span><br><span>              break;</span><br><span>       }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+free_ret:</span><br><span>     msgb_free(msg);</span><br><span>      return rc;</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-hnodeb/+/26032">change 26032</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-hnodeb/+/26032"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-hnodeb </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: If5d5d41693e26f485aa5372129dccf0dcfb7fa6c </div>
<div style="display:none"> Gerrit-Change-Number: 26032 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>