Change in libosmocore[master]: Revert "gb: Fix naming and export symbol bssgp_enc_rim_pdu"

[pespin]

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/24165 )

Change subject: Revert "gb: Fix naming and export symbol bssgp_enc_rim_pdu"
......................................................................

Revert "gb: Fix naming and export symbol bssgp_enc_rim_pdu"

This reverts commit 43ad616e4b66913eedc54f136addcc961b6402f8.

 _enc_ functions are for some ies while the _encode_ and _decode_ are
for the full pdu.  so the old name is correct.

Change-Id: Ib0b4a6fd7f8c96e4647a373541e3cccb324c6a11
---
M include/osmocom/gprs/gprs_bssgp_rim.h
M src/gb/gprs_bssgp_rim.c
M src/gb/libosmogb.map
3 files changed, 3 insertions(+), 4 deletions(-)

Approvals:
  pespin: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/include/osmocom/gprs/gprs_bssgp_rim.h b/include/osmocom/gprs/gprs_bssgp_rim.h
index 41d7982..5f397c9 100644
--- a/include/osmocom/gprs/gprs_bssgp_rim.h
+++ b/include/osmocom/gprs/gprs_bssgp_rim.h
@@ -267,6 +267,6 @@
 };
 
 int bssgp_parse_rim_pdu(struct bssgp_ran_information_pdu *pdu, const struct msgb *msg);
-struct msgb *bssgp_enc_rim_pdu(const struct bssgp_ran_information_pdu *pdu);
+struct msgb *bssgp_encode_rim_pdu(const struct bssgp_ran_information_pdu *pdu);
 
 int bssgp_tx_rim(const struct bssgp_ran_information_pdu *pdu, uint16_t nsei);
diff --git a/src/gb/gprs_bssgp_rim.c b/src/gb/gprs_bssgp_rim.c
index 00b3826..63b303e 100644
--- a/src/gb/gprs_bssgp_rim.c
+++ b/src/gb/gprs_bssgp_rim.c
@@ -1059,7 +1059,7 @@
 /*! Encode a given rim-pdu struct into a message buffer.
  *  \param[out] pdu user provided memory that contains the RAN INFORMATION PDU to encode.
  *  \returns BSSGP message buffer on sccess, NULL on error. */
-struct msgb *bssgp_enc_rim_pdu(const struct bssgp_ran_information_pdu *pdu)
+struct msgb *bssgp_encode_rim_pdu(const struct bssgp_ran_information_pdu *pdu)
 {
 	struct msgb *msg = bssgp_msgb_alloc();
 	struct bssgp_normal_hdr *bgph;
@@ -1160,7 +1160,7 @@
 	char ri_dest_str[64];
 
 	/* Encode RIM PDU into mesage buffer */
-	msg = bssgp_enc_rim_pdu(pdu);
+	msg = bssgp_encode_rim_pdu(pdu);
 	if (!msg) {
 		LOGP(DLBSSGP, LOGL_ERROR,
 		     "BSSGP RIM (NSEI=%u) unable to encode BSSGP RIM PDU\n", nsei);
diff --git a/src/gb/libosmogb.map b/src/gb/libosmogb.map
index 44e622c..db638f9 100644
--- a/src/gb/libosmogb.map
+++ b/src/gb/libosmogb.map
@@ -20,7 +20,6 @@
 bssgp_enc_ran_inf_app_cont_nacc;
 bssgp_enc_ran_inf_app_err_rim_cont;
 bssgp_enc_ran_inf_rim_cont;
-bssgp_enc_rim_pdu;
 bssgp_fc_in;
 bssgp_fc_init;
 bssgp_fc_ms_init;

-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/24165
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ib0b4a6fd7f8c96e4647a373541e3cccb324c6a11
Gerrit-Change-Number: 24165
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin at sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-Reviewer: pespin <pespin at sysmocom.de>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210506/f858a77b/attachment.htm>