<p>pespin <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/24165">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  pespin: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Revert "gb: Fix naming and export symbol bssgp_enc_rim_pdu"<br><br>This reverts commit 43ad616e4b66913eedc54f136addcc961b6402f8.<br><br> _enc_ functions are for some ies while the _encode_ and _decode_ are<br>for the full pdu.  so the old name is correct.<br><br>Change-Id: Ib0b4a6fd7f8c96e4647a373541e3cccb324c6a11<br>---<br>M include/osmocom/gprs/gprs_bssgp_rim.h<br>M src/gb/gprs_bssgp_rim.c<br>M src/gb/libosmogb.map<br>3 files changed, 3 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmocom/gprs/gprs_bssgp_rim.h b/include/osmocom/gprs/gprs_bssgp_rim.h</span><br><span>index 41d7982..5f397c9 100644</span><br><span>--- a/include/osmocom/gprs/gprs_bssgp_rim.h</span><br><span>+++ b/include/osmocom/gprs/gprs_bssgp_rim.h</span><br><span>@@ -267,6 +267,6 @@</span><br><span> };</span><br><span> </span><br><span> int bssgp_parse_rim_pdu(struct bssgp_ran_information_pdu *pdu, const struct msgb *msg);</span><br><span style="color: hsl(0, 100%, 40%);">-struct msgb *bssgp_enc_rim_pdu(const struct bssgp_ran_information_pdu *pdu);</span><br><span style="color: hsl(120, 100%, 40%);">+struct msgb *bssgp_encode_rim_pdu(const struct bssgp_ran_information_pdu *pdu);</span><br><span> </span><br><span> int bssgp_tx_rim(const struct bssgp_ran_information_pdu *pdu, uint16_t nsei);</span><br><span>diff --git a/src/gb/gprs_bssgp_rim.c b/src/gb/gprs_bssgp_rim.c</span><br><span>index 00b3826..63b303e 100644</span><br><span>--- a/src/gb/gprs_bssgp_rim.c</span><br><span>+++ b/src/gb/gprs_bssgp_rim.c</span><br><span>@@ -1059,7 +1059,7 @@</span><br><span> /*! Encode a given rim-pdu struct into a message buffer.</span><br><span>  *  \param[out] pdu user provided memory that contains the RAN INFORMATION PDU to encode.</span><br><span>  *  \returns BSSGP message buffer on sccess, NULL on error. */</span><br><span style="color: hsl(0, 100%, 40%);">-struct msgb *bssgp_enc_rim_pdu(const struct bssgp_ran_information_pdu *pdu)</span><br><span style="color: hsl(120, 100%, 40%);">+struct msgb *bssgp_encode_rim_pdu(const struct bssgp_ran_information_pdu *pdu)</span><br><span> {</span><br><span>        struct msgb *msg = bssgp_msgb_alloc();</span><br><span>       struct bssgp_normal_hdr *bgph;</span><br><span>@@ -1160,7 +1160,7 @@</span><br><span>       char ri_dest_str[64];</span><br><span> </span><br><span>    /* Encode RIM PDU into mesage buffer */</span><br><span style="color: hsl(0, 100%, 40%);">- msg = bssgp_enc_rim_pdu(pdu);</span><br><span style="color: hsl(120, 100%, 40%);">+ msg = bssgp_encode_rim_pdu(pdu);</span><br><span>     if (!msg) {</span><br><span>          LOGP(DLBSSGP, LOGL_ERROR,</span><br><span>                 "BSSGP RIM (NSEI=%u) unable to encode BSSGP RIM PDU\n", nsei);</span><br><span>diff --git a/src/gb/libosmogb.map b/src/gb/libosmogb.map</span><br><span>index 44e622c..db638f9 100644</span><br><span>--- a/src/gb/libosmogb.map</span><br><span>+++ b/src/gb/libosmogb.map</span><br><span>@@ -20,7 +20,6 @@</span><br><span> bssgp_enc_ran_inf_app_cont_nacc;</span><br><span> bssgp_enc_ran_inf_app_err_rim_cont;</span><br><span> bssgp_enc_ran_inf_rim_cont;</span><br><span style="color: hsl(0, 100%, 40%);">-bssgp_enc_rim_pdu;</span><br><span> bssgp_fc_in;</span><br><span> bssgp_fc_init;</span><br><span> bssgp_fc_ms_init;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/24165">change 24165</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/24165"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ib0b4a6fd7f8c96e4647a373541e3cccb324c6a11 </div>
<div style="display:none"> Gerrit-Change-Number: 24165 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>