Change in pysim[master]: transport: Mark more methods as abstractmethod

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

laforge gerrit-no-reply at lists.osmocom.org
Tue May 4 14:22:58 UTC 2021


laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/24110 )

Change subject: transport: Mark more methods as abstractmethod
......................................................................

transport: Mark more methods as abstractmethod

Change-Id: Ied3dbd07fdd0d3fa9bbe2dd7dd674700cf13bf63
---
M pySim/transport/__init__.py
1 file changed, 4 insertions(+), 4 deletions(-)

Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, approved



diff --git a/pySim/transport/__init__.py b/pySim/transport/__init__.py
index 05edc98..5311d8f 100644
--- a/pySim/transport/__init__.py
+++ b/pySim/transport/__init__.py
@@ -52,6 +52,7 @@
 		"""Set an (optional) status word interpreter."""
 		self.sw_interpreter = interp
 
+	@abc.abstractmethod
 	def wait_for_card(self, timeout:int=None, newcardonly:bool=False):
 		"""Wait for a card and connect to it
 
@@ -59,22 +60,21 @@
 		   timeout : Maximum wait time in seconds (None=no timeout)
 		   newcardonly : Should we wait for a new card, or an already inserted one ?
 		"""
-		pass
 
+	@abc.abstractmethod
 	def connect(self):
 		"""Connect to a card immediately
 		"""
-		pass
 
+	@abc.abstractmethod
 	def disconnect(self):
 		"""Disconnect from card
 		"""
-		pass
 
+	@abc.abstractmethod
 	def reset_card(self):
 		"""Resets the card (power down/up)
 		"""
-		pass
 
 	def send_apdu_raw(self, pdu:str):
 		"""Sends an APDU with minimal processing

-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/24110
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ied3dbd07fdd0d3fa9bbe2dd7dd674700cf13bf63
Gerrit-Change-Number: 24110
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <laforge at osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy at sysmocom.de>
Gerrit-Reviewer: laforge <laforge at osmocom.org>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osmocom.org/pipermail/gerrit-log/attachments/20210504/52cd603a/attachment.htm>


More information about the gerrit-log mailing list