<p>laforge <strong>submitted</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/pysim/+/24110">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">transport: Mark more methods as abstractmethod<br><br>Change-Id: Ied3dbd07fdd0d3fa9bbe2dd7dd674700cf13bf63<br>---<br>M pySim/transport/__init__.py<br>1 file changed, 4 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/pySim/transport/__init__.py b/pySim/transport/__init__.py</span><br><span>index 05edc98..5311d8f 100644</span><br><span>--- a/pySim/transport/__init__.py</span><br><span>+++ b/pySim/transport/__init__.py</span><br><span>@@ -52,6 +52,7 @@</span><br><span>            """Set an (optional) status word interpreter."""</span><br><span>               self.sw_interpreter = interp</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+      @abc.abstractmethod</span><br><span>  def wait_for_card(self, timeout:int=None, newcardonly:bool=False):</span><br><span>           """Wait for a card and connect to it</span><br><span> </span><br><span>@@ -59,22 +60,21 @@</span><br><span>                   timeout : Maximum wait time in seconds (None=no timeout)</span><br><span>             newcardonly : Should we wait for a new card, or an already inserted one ?</span><br><span>                 """</span><br><span style="color: hsl(0, 100%, 40%);">-              pass</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+      @abc.abstractmethod</span><br><span>  def connect(self):</span><br><span>           """Connect to a card immediately</span><br><span>              """</span><br><span style="color: hsl(0, 100%, 40%);">-              pass</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+      @abc.abstractmethod</span><br><span>  def disconnect(self):</span><br><span>                """Disconnect from card</span><br><span>               """</span><br><span style="color: hsl(0, 100%, 40%);">-              pass</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+      @abc.abstractmethod</span><br><span>  def reset_card(self):</span><br><span>                """Resets the card (power down/up)</span><br><span>            """</span><br><span style="color: hsl(0, 100%, 40%);">-              pass</span><br><span> </span><br><span>     def send_apdu_raw(self, pdu:str):</span><br><span>            """Sends an APDU with minimal processing</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/pysim/+/24110">change 24110</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/pysim/+/24110"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: pysim </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ied3dbd07fdd0d3fa9bbe2dd7dd674700cf13bf63 </div>
<div style="display:none"> Gerrit-Change-Number: 24110 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@osmocom.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>